This warning is caused by the fortify.h header that has a
system-reserved macro name. This commit simply adds a pragma to tell
Clang that the header is a system header.
I surrounded the pragma with `#ifdef __clang__` and such in case this
header is used for GCC or other compilers, but according to a Gentoo
maintainer, this is not strictly necessary.
I incremented the revision number on 15.0.7-4, 16.0.0, and
17.0.0_pre20230314 but I did not increment them on 16.0.0.999 and
17.0.0.999. I may be wrong, but it doesn't seem like revisions should be
incremented on ebuilds that follow the latest commits of projects.
I thought I had read about that somewhere, but the only source I could
find was [1], and that one did not mention anything about 9999-type
ebuilds and revision numbers.
That said, [2] did have an example where a _pre* ebuild had a revision
number, so I specifically added a revision number to 17.0.0_pre20230314.
Also, [1] said to not add a revision number if the fix is trivial and
would not be worth it with the compile times. However, this package is
trivial to "compile" since it only installs certain files, so I thought
it worth it to increment revisions.
If the Gentoo authors disagree, I don't mind at all, though.
[1]: https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html
[2]: https://devmanual.gentoo.org/ebuild-writing/file-format/index.html#file-naming-rules
Signed-off-by: Gavin D. Howard <gavin@gavinhoward.com>
Closes: https://github.com/gentoo/gentoo/pull/30276
Signed-off-by: Michał Górny <mgorny@gentoo.org>
The configure script is currently looking for the host's keysymdef.h.
We need to pass in the --with-keysymdefdir option so we can look in the
target's sysroot.
Before this change:
checking keysym definitions... configure: error: Cannot find keysymdef.h
After this change:
checking keysym definitions...
/build/arm64-generic/usr/include/X11/keysymdef.h
/build/arm64-generic/usr/include/X11/XF86keysym.h
/build/arm64-generic/usr/include/X11/Sunkeysym.h
/build/arm64-generic/usr/include/X11/DECkeysym.h
/build/arm64-generic/usr/include/X11/HPkeysym.h
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Closes: https://github.com/gentoo/gentoo/pull/30294
Signed-off-by: Matt Turner <mattst88@gentoo.org>
We don't want to look at the host's keysymdef.h, but the target board's
version.
--with-keysymdefdir=DIR The location of keysymdef.h (defaults to xproto
include dir)
Without this change we get the following:
checking keysym definitions... /usr/include/X11/keysymdef.h
/usr/include/X11/XF86keysym.h /usr/include/X11/Sunkeysym.h
/usr/include/X11/DECkeysym.h /usr/include/X11/HPkeysym.h
With this change:
checking keysym definitions...
/build/arm64-generic/usr/include/X11/keysymdef.h
/build/arm64-generic/usr/include/X11/XF86keysym.h
/build/arm64-generic/usr/include/X11/Sunkeysym.h
/build/arm64-generic/usr/include/X11/DECkeysym.h
/build/arm64-generic/usr/include/X11/HPkeysym.h
Signed-off-by: Raul E Rangel <rrangel@chromium.org>
Signed-off-by: Matt Turner <mattst88@gentoo.org>
Sam James
Alfredo Tupone
Andrew Ammerlaan
Mike Gilbert
Gavin D. Howard
Michał Górny
Raul E Rangel
Florian Schmaus