We apply patches to Makefile.am, so we must run eautomake (but running
all of eautoreconf isn't necessary). Successfully doing so requires
knowing exactly which version of automake to use, which works great as
it is slotted, except we did not in fact actually specify it.
In theory, autotools.eclass detects mismatches and forces a full
eautoreconf. This is broken in two ways:
- I had originally optimistically set WANT_AUTOCONF=none, so we might
not have what we need in such a case
- the logic is actually broken, entwined with the effects of a commit
from 2009 in gentoo-historical-2.git: 773f4f230b88ffbcc9de281f83dbd1c905965564
This wiped out WANT_AUTOMAKE= when checking the installed version due
to ??? (it was 2009 so who knows whether it was always broken or is
simply incompatible with later changes any time in the next 16 years)
and causes automake to "see" a different version for comparison than
the one that actually runs. The eclass is clearly broken *today*
either way, and investigation is ongoing as to how to fix it, but this
is a moot point for the purpose of sys-devel/patch...
I originally didn't notice this as Patch was created with automake 1.16,
which was also the latest version stable in Gentoo. Well erm, sort of.
1.17 was stabled barely a day ago and I simply hadn't gotten upgraded to
it yet. Oops. "configure.ac:33: error: version mismatch."
Forcing the correct slotted automake solves all (okay fine, *most* of)
our problems.
Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
update EAPI 7 -> 8
useflags:
add test
add utils (previsously enabled by default, rdep breakout checked)
rm doc (no bdep, small size)
rm debug (no action)
cmakeargs:
force compliance with useflags (SWORD_NO_*)
rm rpath
add patch to respect user's CFLAGS
Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
Closes: https://github.com/gentoo/gentoo/pull/40748
Signed-off-by: Sam James <sam@gentoo.org>
deps:
* add pkg from x11-libs/ to prevent auto-rdep
could be an useflag per pkg but forced here, as xcursor and xrandr
* fontconfig is required by xft option (truetype useflag)
* rm libpng as support is now built-in
patches instead of sed
Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
Closes: https://github.com/gentoo/gentoo/pull/40761
Signed-off-by: Sam James <sam@gentoo.org>
-Wno-compound-token-split-by-macro is not required since -Werror is removed correctly
Signed-off-by: Z. Liu <zhixu.liu@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
Yes I know, we were trying to move on from needing patch to build patch.
On the plus side we are getting really close to a well polished stable
release? Worth it.
Closes: https://bugs.gentoo.org/949834
Acked-by: Sam James <sam@gentoo.org>
Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
The tests for cherrytree were restricted, with a comment that
dependencies were not available in Gentoo. Upon further investigation
and with confirmation from the upstream maintainer
(giuspen/cherrytree#2645), the test dependencies have since changed, and
now everything needed to run the tests is available. This change updates
the dependencies and enables the tests, limiting the number of jobs due
to a limitation in the test suite (giuspen/cherrytree#2663).
Signed-off-by: Joel Anderson <joel@goatshriek.com>
Closes: https://github.com/gentoo/gentoo/pull/40462
Signed-off-by: Sam James <sam@gentoo.org>
Hans de Graaff
Eli Schwartz
Sam James
Michal Rostecki
Nicolas PARLANT
Z. Liu
Mario Haustein
Michał Górny
Joel Anderson