This was added to workaround "PYTHONHOME not set. The Python plugin will not be available" warning. Even though it prints this warning, it will still find Python using pkgconfig and build the plugin.
Signed-off-by: Andrei Sabalenka <mechakotik@gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/38795
Signed-off-by: Conrad Kostecki <conikost@gentoo.org>
Mostly to be easier to maintain, see also bug #938658.
Few notes:
- use SLOT=0 to avoid looking inconsistent when godot5 exists
- not doing slotmove given if a package in an overlay (none
in-tree) depended on godot:4 and has a game invoke godot
with "4" it'll be broken with this version
- no !blocker given all this does is drop the 4 suffix, so
no files conflict (essentially a new slot, except the old
ones were dropped), users that didn't want a specific slot
and using .desktop to start it won't notice a thing after
depclean the old
- USE=runner was intended for packaging games with system godot
but that never really been used and games would be break too
frequently even if we did without doing major.minor slots
(dropping it also allows to build faster), could revisit if
we really want this possibly with a separate godot-runner
slotted package (aka a simplified build without much work to
adapt to slots)
Closes: https://bugs.gentoo.org/938658
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
Upon consideration, we'll no longer be slotting godot (bug
#938658 was a trigger, but been consider undoing this for
a long time either way).
Not *essential* to remove these now given they will not
conflict with SLOT=0, but would rather cleanup at same
time to avoid confusion. As a bonus, it drops consumers
of embree:3 wrt bug #938522 and a lot of patches.
Considered keeping the 3.x (even unslotted) given it's still
supported, but release cycle is slow and it issues with new
python/gcc add to the maintenance burden. Been a while since
godot4 been released, so hopefully most users migrated.
Bug: https://bugs.gentoo.org/938522
Bug: https://bugs.gentoo.org/938658
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
Decent odds that overlooked something given many mundane changes
were done to the build system and it makes it hard to make out the
important changes by diff'ing. Changelog is also too long to read
(really), and highlights are not aimed at packagers.
Notably adds wayland support, albeit building gui without X
doesn't work so well yet. As such not adding IUSE="X" yet.
libdecor could be optional even with USE=wayland, but felt that
it isn't worth its own USE.
Note using system miniupnpc is still broken without patching,
so leaving that alone for now.
Attempted to use mbedtls-3.x given it bundles 3.6.0, but there
is some caveats that prevent it (see ebuild comment). It still
supports 2.x, so just going to keep the upper bound for now.
Have not tested musl but the old patch should be obsolete
thanks to the new execinfo option which does the same thing
we were doing (disables crash handler).
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
Using git:// is a really bad idea and the eclass yells at you for it.
And the second uri does not actually exist (anymore).
Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
It is a no-op. In gentoo-historical-2.git, the addition of version 2.4.3
to the tree reworked the econf flags and dropped the functionality of
actually passing $(use_enable) based on this USE flag.
https://gitweb.gentoo.org/archive/repo/gentoo-2.git/commit/?id=dde0b5c459de07f06abeea223a9fe5612bdc0ab1
One might ponder why the flag should exist at all, if no one used it. In
fact, due to EAPI 7 it was always installed. :( That being said, the
other slots for this package supported it correctly, which means by
default they weren't installed.
Fix this slot to act the same way: correctly.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
It uses a heavily vintage autoconf 2.59 and libtool 1.5.22, which emits
an autoconf-based Modern C warning in configure probes and isn't
currently patch'able for e.g. LTO warning flags by elibtoolize.
Closes: https://bugs.gentoo.org/898980
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Eli Schwartz <eschwartz@gentoo.org>
Likely an easy fix, but no time to look at this right now and
would rather not set a upper bound given hard to say how long this
will stay broken as upstream relies on the bundled copy.
Will check if can revert this on bump.
Closes: https://bugs.gentoo.org/934044
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
But it's a generated automake Makefile.in, and the sed is removing every
line containing "CC = @CC@", so it's puzzling that anyone ever thought
to do this.
It was originally added in gentoo-historical-2:
29 Jan 2009; Michael Sterrett <mr_bones_@gentoo.org> libnw-1.30.02.ebuild:
EAPI=2; respect CC
And 15 years later it's the same (2003) tarball and the sed is decidedly
not needed (nor ever was).
Remove this bloaty junk.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
This is an especially vintage configure script. It was generated by
autoconf 2.13, and the tarball is dated 2003.
It failed pretty early on:
configure: error: installation or configuration problem: C compiler cannot create executables.
(There are still other modern C porting errors.)
Closes: https://bugs.gentoo.org/875065
Closes: https://bugs.gentoo.org/909546
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
Meant to wait until a release to test given it'd likely include
3.12 fixes if any are needed, but SLOT=3 releases have gotten
sparse and it seems to be build fine (only used for scons).
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
Would rather not have to worry about this, esp when generated
bits are involved. May reconsider eventually.
Closes: https://bugs.gentoo.org/921017
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
Won't bother with godot*-runner.
Skipping revbump given this is a long build and most users are likely
not using shell commands and work through the GUI (which may explain
why the only report for this being broken was automated).
(missed QA myself given it only shows if bash-completion is installed)
Closes: https://bugs.gentoo.org/927855
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
Feel free to file a bug if really still need these branches
while upstream still supports them, but for now dropping to
reduce maintenance/testing costs.
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
Michael Mair-Keimberger
Andrei Sabalenka
Sam James
Joonas Niilola
Petr Vaněk
Ionen Wolkens
Eli Schwartz
Pacho Ramos
Eli Schwartz
Michał Górny
Arthur Zamarin
Matt Turner
Lucio Sauer
Andreas Sturmlechner
Azamat H. Hackimov
Alexey Sokolov