gentoo-mirror/gentoo
1
0
Fork 0
mirror of https://github.com/gentoo-mirror/gentoo.git synced 2026-09-23 16:49:10 -07:00
Code Issues Projects Releases Wiki Activity

dev-games/aseprite: mark as LTO-unsafe, strict-aliasing unsafe

Browse Source 
It has all the issues, and then throws in another issue with a bundled
skia too just for kicks.

Closes: https://bugs.gentoo.org/924692
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
This commit is contained in:
Eli Schwartz
2024-04-11 14:40:06 -04:00
committed by Sam James
parent ce55c48a68
commit 95f26136ee
2 changed files with 28 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
dev-games/aseprite/aseprite-1.2.40.ebuild
View File

@@ -5,7 +5,7 @@ EAPI=8
PYTHON_COMPAT=( python3_{10..12} )
inherit cmake desktop ninja-utils python-any-r1 toolchain-funcs xdg-utils
inherit cmake desktop flag-o-matic ninja-utils python-any-r1 toolchain-funcs xdg-utils
SKIA_VER="m102"
# Last commit in ${SKIA_VER} feature branch
@@ -96,6 +96,19 @@ src_prepare() {
}
src_configure() {
# -Werror=strict-aliasing, -Werror=odr, -Werror=lto-type-mismatch
# https://bugs.gentoo.org/924692
# https://github.com/aseprite/aseprite/issues/4413
#
# There is a bundled skia that fails with ODR errors. When excluding just
# skia from testing, aseprite itself fails with strict-aliasing, and when
# that is disabled, fails again with ODR and lto-type-mismatch issues.
#
# There are a lot of issues, so don't trust any fixes without thorough
# testing.
append-flags -fno-strict-aliasing
filter-lto
einfo "Skia configuration"
cd "${WORKDIR}/skia-${SKIA_REV}" || die

15
dev-games/aseprite/aseprite-1.3.2.ebuild
View File

@@ -5,7 +5,7 @@ EAPI=8
PYTHON_COMPAT=( python3_{10..12} )
inherit cmake desktop python-any-r1 toolchain-funcs xdg-utils
inherit cmake desktop flag-o-matic python-any-r1 toolchain-funcs xdg-utils
SKIA_VER="m102"
# Last commit in ${SKIA_VER} feature branch
@@ -96,6 +96,19 @@ src_prepare() {
}
src_configure() {
# -Werror=strict-aliasing, -Werror=odr, -Werror=lto-type-mismatch
# https://bugs.gentoo.org/924692
# https://github.com/aseprite/aseprite/issues/4413
#
# There is a bundled skia that fails with ODR errors. When excluding just
# skia from testing, aseprite itself fails with strict-aliasing, and when
# that is disabled, fails again with ODR and lto-type-mismatch issues.
#
# There are a lot of issues, so don't trust any fixes without thorough
# testing.
append-flags -fno-strict-aliasing
filter-lto
einfo "Skia configuration"
cd "${WORKDIR}/skia-${SKIA_REV}" || die