The situation here is complicated. With C23, 'bool' is exposed properly
out of the box (as the same type as '_Bool'). But this is problematic
when it comes to C++ where 'bool' was always '_Bool' (or near-enough
guaranteed), and where we have existing C applications that we don't
want to break ABI for.
For C++, id3tag was always using native C++ 'bool', so we don't want to change
that now when looking at C23 compat. This means the ABI issues between
C and C++ remain: typedef bool my_bool.
For C, continue using the old 'int bool' that the project did before
C23. This doesn't solve the pre-existing C/C++ ABI issue here where
C++ always had "good _Bool-as-bool", unfortunately: typedef int my_bool.
Really, we need people to port to taglib ASAP.
Bug: https://bugs.gentoo.org/893644
Bug: https://bugs.gentoo.org/949086
Signed-off-by: Sam James <sam@gentoo.org>
fix compilation with gcc-15/c23 for media-sound/easytag
> In file included from /usr/include/id3.h:32,
> from src/tags/id3_tag.c:39:
> /usr/include/id3/globals.h:87:13: error: ‘bool’
> cannot be defined via ‘typedef’
> 87 | typedef int bool;
> | ^~~~
> /usr/include/id3/globals.h:87:13: note: ‘bool’ is
> a keyword with ‘-std=c23’ onwards
[sam: Revbump for changed installed header.]
Closes: https://bugs.gentoo.org/949086
Signed-off-by: Nicolas PARLANT <nicolas.parlant@parhuet.fr>
Closes: https://github.com/gentoo/gentoo/pull/40134
Signed-off-by: Sam James <sam@gentoo.org>
Several reports on NVIDIA's forums (and some old news posts) point
to requiring the open variant for blackwell, not that it's something
I've verified myself.
In the future may possibly try to implement a postinst check to verify
if usage of USE=kernel-open is correct. Currently the .json file has
a 'kernelopen" to know if it's usable but does not say whether it's
required or not for blackwell at the moment.
May also need to consider making USE=kernel-open default eventually,
albeit that could potentially wait until non-GSP cards are tossed in
a legacy branch then the new branch could be kernel-open-only.
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
This clearly can't have worked before, I either lost a hunk when staging
w/ git add -p or committed it before it was ready and forgot to go back
to it.
Bug: https://bugs.gentoo.org/949051
Signed-off-by: Sam James <sam@gentoo.org>
* QtQml tests expect QtQuick support.
* Add build_dir.txt files to ensure tests use the right build directory.
* Explicitly feed --projects so that USE="-core" works with tests.
* Add tests of xfail and conditional xfail for numpy tests.
Signed-off-by: Alfred Wingate <parona@protonmail.com>
Closes: https://github.com/gentoo/gentoo/pull/40437
Signed-off-by: Nowa Ammerlaan <nowa@gentoo.org>