sci-mathematics/otter: fix lto mismatch + build w/ upcoming clang16

Closes: https://bugs.gentoo.org/863257
Closes: https://bugs.gentoo.org/871423
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

sci-mathematics/otter/files/otter-3.3-clang16.patch

@@ -0,0 +1,23 @@
+https://bugs.gentoo.org/863257
+https://bugs.gentoo.org/871423
+--- a/mace2/anldp.c
++++ b/mace2/anldp.c
+@@ -51,2 +51,4 @@
+ 
++#include "../source/header.h"
++
+ int First_order;        /* used by dp.c */
+--- a/source/formed/display.c
++++ b/source/formed/display.c
+@@ -588,3 +588,3 @@
+ 
+-setup_operator_pixmaps(font_string)
++void setup_operator_pixmaps(font_string)
+ char font_string[];
+--- a/source/formed/formed.c
++++ b/source/formed/formed.c
+@@ -15,3 +15,3 @@
+ 
+-main(argc, argv)
++int main(argc, argv)
+ int argc;

sci-mathematics/otter/otter-3.3-r4.ebuild

@@ -1,4 +1,4 @@
-# Copyright 1999-2020 Gentoo Authors
+# Copyright 1999-2022 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
@@ -22,14 +22,17 @@ DEPEND="${RDEPEND}"
 PATCHES=(
 	"${FILESDIR}"/${P}-build.patch
 	"${FILESDIR}"/${P}-gold.patch
+	"${FILESDIR}"/${P}-clang16.patch
 )
 
 src_configure() {
 	append-cflags -fcommon
+	append-cflags -std=gnu89 # old codebase, incompatible with c2x
+	append-cppflags -D_GNU_SOURCE #871423 (gethostname, caddr_t)
 }
 
 src_compile() {
-	tc-export CC
+	tc-export AR CC
 
 	emake -C source
 	emake -C mace2