x11-misc/xscreensaver-app: Fix passing argument from incompatible pointer

And update EAPI 7 -> 8

Closes: https://bugs.gentoo.org/924177
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
Closes: https://github.com/gentoo/gentoo/pull/35353
Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

x11-misc/xscreensaver-app/files/xscreensaver-app-2.3-gcc14-build-fix.patch

@@ -0,0 +1,12 @@
+Bug: https://bugs.gentoo.org/924177
+--- a/xscreensaver.app.c
++++ b/xscreensaver.app.c
+@@ -116,7 +116,7 @@ void popConfig()
+ 
+ int main(int argc, char **argv)
+ {
+-  unsigned height, width;
++  unsigned short height, width;
+   char *st_command;
+   int status;
+ 

x11-misc/xscreensaver-app/xscreensaver-app-2.3-r5.ebuild

@@ -0,0 +1,51 @@
+# Copyright 1999-2024 Gentoo Authors
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=8
+inherit autotools
+
+MY_PN=${PN/-a/.A}
+MY_PN=${MY_PN/xs/XS}
+MY_PN=${MY_PN/s/S}
+
+DESCRIPTION="XScreenSaver dockapp for the Window Maker window manager"
+HOMEPAGE="https://xscreensaverapp.sourceforge.net/"
+SRC_URI="mirror://sourceforge/project/xscreensaverapp/${MY_PN}/${PV}/${MY_PN}-${PV}.tar.gz"
+
+SLOT="0"
+LICENSE="GPL-2"
+KEYWORDS="~amd64 ~x86"
+
+CDEPEND="
+	x11-libs/libdockapp
+	x11-libs/libX11
+"
+DEPEND="
+	${CDEPEND}
+	virtual/pkgconfig
+	x11-base/xorg-proto
+"
+RDEPEND="
+	${CDEPEND}
+	x11-misc/xscreensaver
+"
+
+S=${WORKDIR}/${MY_PN}-${PV}
+
+PATCHES=(
+	"${FILESDIR}/${PN}-2.3-gcc14-build-fix.patch"
+)
+
+src_prepare() {
+	rm configure.in || die
+	cp "${FILESDIR}"/${PN}-2.3-configure.ac configure.ac || die
+
+	default
+
+	eautoreconf
+}
+
+src_install() {
+	dobin ${MY_PN}
+	dodoc README NEWS ChangeLog TODO AUTHORS
+}