gui-apps/deskflow: Backport upstream patch to fix client crash

Thanks to Christian Schmidt.

Closes: https://bugs.gentoo.org/961039
Signed-off-by: James Le Cuirot <chewi@gentoo.org>
This commit is contained in:
James Le Cuirot 2025-08-04 21:52:41 +01:00
parent e4800aabde
commit 6507f47e81
No known key found for this signature in database
GPG Key ID: 1226415D00DD3137
2 changed files with 29 additions and 0 deletions

View File

@ -58,6 +58,10 @@ DOCS=(
doc/user/configuration.md
)
PATCHES=(
"${FILESDIR}"/${P}-default-proto.patch
)
src_configure() {
local mycmakeargs=(
-DBUILD_GUI=$(usex gui)

View File

@ -0,0 +1,25 @@
fix: server: initialize the m_protocol member with a default value
It is likely random whether the server works or not without
a manually configured protocol option, which is neither documented
nor enforced to be set.
With a random uninitialized value in m_protocol, this can happen:
[2025-08-03T12:39:57] NOTE: accepted client connection
[2025-08-03T12:39:57] FATAL: a runtime error occurred: XInvalidProtocol
Reports of "it works with debug enabled" are likely due to having
parts of the memory space the server object is allocated into being
cleared, and thus having a 0 (Synergy) startup value.
This patch had been modified to apply against 1.23.0
--- a/src/lib/server/Server.h
+++ b/src/lib/server/Server.h
@@ -358,7 +358,7 @@ private:
};
// used in hello message sent to the client
- ENetworkProtocol m_protocol;
+ ENetworkProtocol m_protocol = ENetworkProtocol::kSynergy;
// the primary screen client
PrimaryClient *m_primaryClient;