mirror of
https://github.com/gentoo-mirror/gentoo.git
synced 2026-11-21 10:37:22 -08:00
toolchain.eclass: never pass --enable-libsanitizer to ./configure
gcc treats --enable-libsanitizer as an override on top of autodetection. It it never what we want. Happens to break at least mips cross-compilers and likely many more minor targets. Bug: https://gcc.gnu.org/PR85663 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
This commit is contained in:
+18
-1
@@ -1299,7 +1299,8 @@ toolchain_src_configure() {
|
||||
fi
|
||||
|
||||
if tc_version_is_at_least 4.8 && in_iuse sanitize ; then
|
||||
confgcc+=( $(use_enable sanitize libsanitizer) )
|
||||
# See Note [implicitly enabled flags]
|
||||
confgcc+=( $(usex sanitize '' --disable-libsanitizer) )
|
||||
fi
|
||||
|
||||
if tc_version_is_at_least 6.0 && in_iuse pie ; then
|
||||
@@ -2494,3 +2495,19 @@ toolchain_death_notice() {
|
||||
popd >/dev/null
|
||||
fi
|
||||
}
|
||||
|
||||
# Note [implicitly enabled flags]
|
||||
# -------------------------------
|
||||
# Usually configure-based packages handle explicit feature requests
|
||||
# like
|
||||
# ./configure --enable-foo
|
||||
# as explicit request to check for suppor of 'foo' and bail out at
|
||||
# configure time.
|
||||
#
|
||||
# GCC does not follow this pattern an instead overrides autodetection
|
||||
# of the feature and enables it unconditionally.
|
||||
# See https://gcc.gnu.org/PR85663
|
||||
#
|
||||
# Thus safer way to enable/disable the feature is to rely on implicit
|
||||
# enabled-by-default state:
|
||||
# econf $(usex foo '' --disable-foo)
|
||||
|
||||
Reference in New Issue
Block a user