media-libs/gst-plugins-bad: backport security fixes

Bug: https://bugs.gentoo.org/974283
Bug: https://bugs.gentoo.org/974284
Signed-off-by: Alfred Wingate <parona@protonmail.com>
Part-of: https://codeberg.org/gentoo/gentoo/pulls/527
Signed-off-by: Sam James <sam@gentoo.org>
This commit is contained in:
Alfred Wingate
2026-05-08 18:02:01 +01:00
committed by Sam James
parent 3bcbc1bdcc
commit 4b68df05df
5 changed files with 408 additions and 0 deletions
@@ -0,0 +1,108 @@
https://bugs.gentoo.org/974284
https://gstreamer.freedesktop.org/security/sa-2026-0013.html
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11240
From 9a4bef4892c23b9d156f810d5e1a18ffc774a595 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 26 Mar 2026 18:31:05 +0200
Subject: [PATCH 1/2] h264parse: Remove pointless allocation failure handling
g_new0() already aborts the process on allocation failure.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11240>
--- a/gst-libs/gst/codecparsers/gsth264parser.c
+++ b/gst-libs/gst/codecparsers/gsth264parser.c
@@ -2044,8 +2044,6 @@ gst_h264_parse_sps_mvc_data (NalReader * nr, GstH264SPS * sps)
READ_UE_MAX (nr, mvc->num_views_minus1, GST_H264_MAX_VIEW_COUNT - 1);
mvc->view = g_new0 (GstH264SPSExtMVCView, mvc->num_views_minus1 + 1);
- if (!mvc->view)
- goto error_allocation_failed;
for (i = 0; i <= mvc->num_views_minus1; i++)
READ_UE_MAX (nr, mvc->view[i].view_id, GST_H264_MAX_VIEW_ID);
@@ -2083,8 +2081,6 @@ gst_h264_parse_sps_mvc_data (NalReader * nr, GstH264SPS * sps)
mvc->level_value =
g_new0 (GstH264SPSExtMVCLevelValue,
mvc->num_level_values_signalled_minus1 + 1);
- if (!mvc->level_value)
- goto error_allocation_failed;
for (i = 0; i <= mvc->num_level_values_signalled_minus1; i++) {
GstH264SPSExtMVCLevelValue *const level_value = &mvc->level_value[i];
@@ -2095,8 +2091,6 @@ gst_h264_parse_sps_mvc_data (NalReader * nr, GstH264SPS * sps)
level_value->applicable_op =
g_new0 (GstH264SPSExtMVCLevelValueOp,
level_value->num_applicable_ops_minus1 + 1);
- if (!level_value->applicable_op)
- goto error_allocation_failed;
for (j = 0; j <= level_value->num_applicable_ops_minus1; j++) {
GstH264SPSExtMVCLevelValueOp *const op = &level_value->applicable_op[j];
@@ -2105,8 +2099,6 @@ gst_h264_parse_sps_mvc_data (NalReader * nr, GstH264SPS * sps)
READ_UE_MAX (nr, op->num_target_views_minus1, 1023);
op->target_view_id = g_new (guint16, op->num_target_views_minus1 + 1);
- if (!op->target_view_id)
- goto error_allocation_failed;
for (k = 0; k <= op->num_target_views_minus1; k++)
READ_UE_MAX (nr, op->target_view_id[k], GST_H264_MAX_VIEW_ID);
@@ -2115,11 +2107,6 @@ gst_h264_parse_sps_mvc_data (NalReader * nr, GstH264SPS * sps)
}
return TRUE;
-error_allocation_failed:
- GST_WARNING ("failed to allocate memory");
- gst_h264_sps_clear (sps);
- return FALSE;
-
error:
gst_h264_sps_clear (sps);
return FALSE;
--
GitLab
From 1f823ee39f253fc23ad95e6833281146cad8ecad Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 26 Mar 2026 18:37:50 +0200
Subject: [PATCH 2/2] h264parse: Avoid NULL pointer dereferences when freeing
partially parsed SPS/MVC data
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/4992
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11240>
--- a/gst-libs/gst/codecparsers/gsth264parser.c
+++ b/gst-libs/gst/codecparsers/gsth264parser.c
@@ -2623,15 +2623,19 @@ gst_h264_sps_mvc_clear (GstH264SPS * sps)
g_free (mvc->view);
mvc->view = NULL;
- for (i = 0; i <= mvc->num_level_values_signalled_minus1; i++) {
- GstH264SPSExtMVCLevelValue *const level_value = &mvc->level_value[i];
-
- for (j = 0; j <= level_value->num_applicable_ops_minus1; j++) {
- g_free (level_value->applicable_op[j].target_view_id);
- level_value->applicable_op[j].target_view_id = NULL;
+ if (mvc->level_value) {
+ for (i = 0; i <= mvc->num_level_values_signalled_minus1; i++) {
+ GstH264SPSExtMVCLevelValue *const level_value = &mvc->level_value[i];
+
+ if (level_value->applicable_op) {
+ for (j = 0; j <= level_value->num_applicable_ops_minus1; j++) {
+ g_free (level_value->applicable_op[j].target_view_id);
+ level_value->applicable_op[j].target_view_id = NULL;
+ }
+ }
+ g_free (level_value->applicable_op);
+ level_value->applicable_op = NULL;
}
- g_free (level_value->applicable_op);
- level_value->applicable_op = NULL;
}
g_free (mvc->level_value);
mvc->level_value = NULL;
--
GitLab
@@ -0,0 +1,161 @@
https://bugs.gentoo.org/974283
https://gstreamer.freedesktop.org/security/sa-2026-0014.html
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11259
Modified to apply without
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/commit/b72d4cd6fdf1e42618bec01ee55d58a1717c856b
From 845e9cf7d12da539ee9f4a8e5ce4ce880485c6c2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 26 Mar 2026 18:45:11 +0200
Subject: [PATCH 1/8] av1parse: Avoid signed 32 bit integer overflow when
parsing LEB128 values
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/4994
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11259>
--- a/gst-libs/gst/codecparsers/gstav1parser.c
+++ b/gst-libs/gst/codecparsers/gstav1parser.c
@@ -295,7 +295,7 @@ av1_bitstreamfn_leb128 (GstBitReader * br, GstAV1ParserResult * retval)
if (*retval != GST_AV1_PARSER_OK)
return 0;
- value |= (((gint) leb128_byte & 0x7f) << (i * 7));
+ value |= (((guint64) leb128_byte & 0x7f) << (i * 7));
if (!(leb128_byte & 0x80))
break;
}
--- a/gst/videoparsers/gstav1parse.c
+++ b/gst/videoparsers/gstav1parse.c
@@ -250,7 +250,7 @@ _read_leb128 (guint8 * data, GstAV1ParserResult * retval, guint32 * comsumed)
return 0;
}
- value |= (((gint) leb128_byte & 0x7f) << (i * 7));
+ value |= (((guint64) leb128_byte & 0x7f) << (i * 7));
if (!(leb128_byte & 0x80))
break;
}
--
GitLab
From f9d57db394341bf518725f75d23f22e89b4c2023 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 26 Mar 2026 18:52:48 +0200
Subject: [PATCH 3/8] av1parse: Be more explicit about available data when
parsing LEB128 values
The caller already checks that at least 8 bytes are available, which is the
maximum this function is going to parse anyway, but better to not hardcode this
assumption and instead actually check for it.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11259>
--- a/gst/videoparsers/gstav1parse.c
+++ b/gst/videoparsers/gstav1parse.c
@@ -230,7 +230,8 @@ _obu_name (GstAV1OBUType type)
}
static guint32
-_read_leb128 (guint8 * data, GstAV1ParserResult * retval, guint32 * comsumed)
+_read_leb128 (guint8 * data, gsize size, GstAV1ParserResult * retval,
+ guint32 * comsumed)
{
guint8 leb128_byte = 0;
guint64 value = 0;
@@ -239,7 +240,7 @@ _read_leb128 (guint8 * data, GstAV1ParserResult * retval, guint32 * comsumed)
GstBitReader br;
guint32 cur_pos;
- gst_bit_reader_init (&br, data, 8);
+ gst_bit_reader_init (&br, data, size);
cur_pos = gst_bit_reader_get_pos (&br);
for (i = 0; i < 8; i++) {
@@ -2245,7 +2246,7 @@ again:
goto out;
}
- tu_sz = _read_leb128 (map_info.data, &res, &consumed);
+ tu_sz = _read_leb128 (map_info.data, map_info.size, &res, &consumed);
if (tu_sz == 0 || res != GST_AV1_PARSER_OK) {
/* error to get the TU size, should not be annex b. */
goto out;
--
GitLab
From 6e842602a704503da9f8e000a9a4f054d7a0ddd8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 26 Mar 2026 19:18:33 +0200
Subject: [PATCH 5/8] av1parse: Allow G_MAXUINT32 as LEB128 encoded value
The spec states that any value less than or equal to (1<<32) - 1 should be
accepted but we were rejecting (1<<32) - 1.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11259>
--- a/gst-libs/gst/codecparsers/gstav1parser.c
+++ b/gst-libs/gst/codecparsers/gstav1parser.c
@@ -301,7 +301,7 @@ av1_bitstreamfn_leb128 (GstBitReader * br, GstAV1ParserResult * retval)
}
/* check for bitstream conformance see chapter4.10.5 */
- if (value < G_MAXUINT32) {
+ if (value <= G_MAXUINT32) {
return (guint32) value;
} else {
GST_WARNING ("invalid leb128");
--- a/gst/videoparsers/gstav1parse.c
+++ b/gst/videoparsers/gstav1parse.c
@@ -258,7 +258,7 @@ _read_leb128 (guint8 * data, gsize size, GstAV1ParserResult * retval,
*comsumed = (gst_bit_reader_get_pos (&br) - cur_pos) / 8;
/* check for bitstream conformance see chapter4.10.5 */
- if (value < G_MAXUINT32) {
+ if (value <= G_MAXUINT32) {
*retval = GST_AV1_PARSER_OK;
return (guint32) value;
} else {
--
GitLab
From 00d6368e59f3caeda083c97ec2e1ab99e70aaf3f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 26 Mar 2026 19:26:54 +0200
Subject: [PATCH 7/8] av1parse: Correctly reject LEB128 values where the 8th
byte has the high bit set
This is invalid according to the specification.
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11259>
--- a/gst-libs/gst/codecparsers/gstav1parser.c
+++ b/gst-libs/gst/codecparsers/gstav1parser.c
@@ -298,6 +298,11 @@ av1_bitstreamfn_leb128 (GstBitReader * br, GstAV1ParserResult * retval)
value |= (((guint64) leb128_byte & 0x7f) << (i * 7));
if (!(leb128_byte & 0x80))
break;
+
+ if (i == 7 && leb128_byte & 0x80) {
+ *retval = GST_AV1_PARSER_BITSTREAM_ERROR;
+ return 0;
+ }
}
/* check for bitstream conformance see chapter4.10.5 */
--- a/gst/videoparsers/gstav1parse.c
+++ b/gst/videoparsers/gstav1parse.c
@@ -254,6 +254,11 @@ _read_leb128 (guint8 * data, gsize size, GstAV1ParserResult * retval,
value |= (((guint64) leb128_byte & 0x7f) << (i * 7));
if (!(leb128_byte & 0x80))
break;
+
+ if (i == 7 && leb128_byte & 0x80) {
+ *retval = GST_AV1_PARSER_BITSTREAM_ERROR;
+ return 0;
+ }
}
*comsumed = (gst_bit_reader_get_pos (&br) - cur_pos) / 8;
--
GitLab
@@ -0,0 +1,102 @@
https://bugs.gentoo.org/974284
https://gstreamer.freedesktop.org/security/sa-2026-0015.html
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11236
From d8a55fc3ef4000672cb7163baa2fb5b72156b125 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Mon, 30 Mar 2026 16:29:01 +0300
Subject: [PATCH 1/2] jp2kdecimator: Fix some possible integer overflows in
size checks
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11236>
--- a/gst/jp2kdecimator/jp2kcodestream.c
+++ b/gst/jp2kdecimator/jp2kcodestream.c
@@ -499,7 +499,7 @@ parse_siz (GstJP2kDecimator * self, GstByteReader * reader,
siz->yto = gst_byte_reader_get_uint32_be_unchecked (reader);
siz->n_components = gst_byte_reader_get_uint16_be_unchecked (reader);
- if (length < 38 + 3 * siz->n_components) {
+ if (length < 38 + 3 * (gsize) siz->n_components) {
GST_ERROR_OBJECT (self, "Invalid SIZ marker");
return GST_FLOW_ERROR;
}
@@ -591,9 +591,9 @@ parse_cod (GstJP2kDecimator * self, GstByteReader * reader,
if ((Scod & 0x01)) {
gint i;
- /* User defined precincts */
- if (length < 12 + (Scod & 0x01) * (cod->n_decompositions + 1)) {
+ /* User defined precincts */
+ if (length < 12 + 1 || length - 12 - 1 < cod->n_decompositions) {
GST_ERROR_OBJECT (self, "Invalid COD marker");
return GST_FLOW_ERROR;
}
@@ -1072,8 +1072,8 @@ parse_tile (GstJP2kDecimator * self, GstByteReader * reader,
tile->sot.tile_part_index = gst_byte_reader_get_uint8_unchecked (reader);
tile->sot.n_tile_parts = gst_byte_reader_get_uint8_unchecked (reader);
- if (tile->sot.tile_part_size >
- 2 + 10 + gst_byte_reader_get_remaining (reader)) {
+ if (tile->sot.tile_part_size < 12 || tile->sot.tile_part_size - 12 >
+ gst_byte_reader_get_remaining (reader)) {
GST_ERROR_OBJECT (self, "Truncated tile part");
ret = GST_FLOW_ERROR;
goto done;
@@ -1585,9 +1585,17 @@ parse_main_header (GstJP2kDecimator * self, GstByteReader * reader,
(header->siz.x - header->siz.xto + header->siz.xt - 1) / header->siz.xt;
header->n_tiles_y =
(header->siz.y - header->siz.yto + header->siz.yt - 1) / header->siz.yt;
- header->n_tiles = header->n_tiles_x * header->n_tiles_y;
+ if (header->n_tiles_x == 0 || header->n_tiles_y == 0) {
+ GST_ERROR_OBJECT (self, "Zero tiles in one direction");
+ return GST_FLOW_ERROR;
+ }
+ if (!g_uint_checked_mul (&header->n_tiles, header->n_tiles_x,
+ header->n_tiles_y)) {
+ GST_ERROR_OBJECT (self, "Too many tiles");
+ return GST_FLOW_ERROR;
+ }
- header->tiles = g_malloc0 (sizeof (Tile) * header->n_tiles);
+ header->tiles = g_new0 (Tile, header->n_tiles);
/* now at SOT marker, read the tiles */
{
--
GitLab
From d1f4c2d2c3dc05beac7b0ee0e21f2f283d2290d9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Mon, 30 Mar 2026 16:29:27 +0300
Subject: [PATCH 2/2] jp2kdecimator: Avoid integer overflows and divisions by
zero on invalid tile configurations
Thanks to Sebastian Alba Vives for reporting the issue and suggesting the fix.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/work_items/5008
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11236>
--- a/gst/jp2kdecimator/jp2kcodestream.c
+++ b/gst/jp2kdecimator/jp2kcodestream.c
@@ -1581,6 +1581,16 @@ parse_main_header (GstJP2kDecimator * self, GstByteReader * reader,
return GST_FLOW_ERROR;
}
+ if (header->siz.xt == 0 || header->siz.yt == 0) {
+ GST_ERROR_OBJECT (self, "Invalid zero tile sizes");
+ return GST_FLOW_ERROR;
+ }
+
+ if (header->siz.xto > header->siz.x || header->siz.yto > header->siz.y) {
+ GST_ERROR_OBJECT (self, "Invalid tile origin");
+ return GST_FLOW_ERROR;
+ }
+
header->n_tiles_x =
(header->siz.x - header->siz.xto + header->siz.xt - 1) / header->siz.xt;
header->n_tiles_y =
--
GitLab
@@ -0,0 +1,31 @@
https://bugs.gentoo.org/974284
https://gstreamer.freedesktop.org/security/sa-2026-0017.html
https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11241
From ce1b288d546f58eb35f9d626815a58260cd2b0c1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Sebastian=20Dr=C3=B6ge?= <sebastian@centricular.com>
Date: Thu, 12 Mar 2026 11:14:11 +0200
Subject: [PATCH] h266parser: Avoid integer overflow when parsing profile /
tier / level
And as a result also avoid a stack overflow.
Thanks to Nicholas Soh for finding and analyzing the issue, and suggesting this fix.
Fixes https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/4958
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/11241>
--- a/gst-libs/gst/codecparsers/gsth266parser.c
+++ b/gst-libs/gst/codecparsers/gsth266parser.c
@@ -380,7 +380,7 @@ static gboolean
gst_h266_parse_profile_tier_level (GstH266ProfileTierLevel * ptl,
NalReader * nr, guint8 profileTierPresentFlag, guint8 MaxNumSubLayersMinus1)
{
- gint8 i;
+ gint i;
GST_LOG ("parsing \"Profile Tier Level parameters\"");
--
GitLab
@@ -59,6 +59,12 @@ VERIFY_SIG_OPENPGP_KEY_PATH=/usr/share/openpgp-keys/tpm.asc
PATCHES=(
"${FILESDIR}"/gst-plugins-bad-1.26.11-respect-webrtcdsp-disable.patch
# bug #974283
"${FILESDIR}"/gst-plugins-bad-1.26.11-GStreamer-SA-2026-0014.patch
# bug #974284
"${FILESDIR}"/gst-plugins-bad-1.26.11-GStreamer-SA-2026-0013.patch
"${FILESDIR}"/gst-plugins-bad-1.26.11-GStreamer-SA-2026-0015.patch
"${FILESDIR}"/gst-plugins-bad-1.26.11-GStreamer-SA-2026-0017.patch
)
src_prepare() {