app-emulation/wine-proton: pass -mno-avx with mingw unconditionally

Upon further consideration 84924628f0
result in rather unexpected behavior even if we consider that
USE=custom-cflags is unsupported, and giving a way to skip -mno-avx
may not be all that worth it.

So revert plus tidy and add this bugref.

Closes: https://bugs.gentoo.org/912268
Signed-off-by: Ionen Wolkens <ionen@gentoo.org>
This commit is contained in:
Ionen Wolkens
2023-08-14 06:22:41 -04:00
parent 70b13c64ef
commit 44d2b75c2b
3 changed files with 13 additions and 5 deletions

View File

@@ -269,11 +269,13 @@ src_configure() {
: "${CROSSCFLAGS:=$(
filter-flags '-fstack-protector*' #870136
filter-flags '-mfunction-return=thunk*' #878849
# -mavx with mingw-gcc has a history of obscure issues and
# disabling is seen as safer, e.g. `WINEARCH=win32 winecfg`
# crashes with -march=skylake >=wine-8.10, similar issues with
# znver4: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110273
use custom-cflags || append-cflags -mno-avx
append-cflags -mno-avx #912268
CC=${CROSSCC} test-flags-CC ${CFLAGS:--O2})}"
: "${CROSSLDFLAGS:=$(
filter-flags '-fuse-ld=*'

View File

@@ -273,14 +273,17 @@ src_configure() {
: "${CROSSCFLAGS:=$(
# >=wine-7.21 <8.10's configure.ac does not pass -fno-strict when
# it should (can be removed when proton is rebased on >=8.10)
append-cflags '-fno-strict-aliasing'
append-cflags -fno-strict-aliasing
filter-flags '-fstack-protector*' #870136
filter-flags '-mfunction-return=thunk*' #878849
# -mavx with mingw-gcc has a history of obscure issues and
# disabling is seen as safer, e.g. `WINEARCH=win32 winecfg`
# crashes with -march=skylake >=wine-8.10, similar issues with
# znver4: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110273
use custom-cflags || append-cflags -mno-avx
append-cflags -mno-avx #912268
CC=${CROSSCC} test-flags-CC ${CFLAGS:--O2})}"
: "${CROSSLDFLAGS:=$(
filter-flags '-fuse-ld=*'

View File

@@ -277,14 +277,17 @@ src_configure() {
: "${CROSSCFLAGS:=$(
# >=wine-7.21 <8.10's configure.ac does not pass -fno-strict when
# it should (can be removed when proton is rebased on >=8.10)
append-cflags '-fno-strict-aliasing'
append-cflags -fno-strict-aliasing
filter-flags '-fstack-protector*' #870136
filter-flags '-mfunction-return=thunk*' #878849
# -mavx with mingw-gcc has a history of obscure issues and
# disabling is seen as safer, e.g. `WINEARCH=win32 winecfg`
# crashes with -march=skylake >=wine-8.10, similar issues with
# znver4: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110273
use custom-cflags || append-cflags -mno-avx
append-cflags -mno-avx #912268
CC=${CROSSCC} test-flags-CC ${CFLAGS:--O2})}"
: "${CROSSLDFLAGS:=$(
filter-flags '-fuse-ld=*'