rexy712/nano-with-linefolding
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

tweaks: close a temp file only when descriptor is valid [coverity scan]

Browse Source
This commit is contained in:
Benno Schulenberg 2018-07-14 21:27:50 +02:00
parent 89c0e7493f
commit 6d3b16b761
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/text.c
View File

@ -2661,8 +2661,10 @@ const char *do_int_speller(const char *tempfile_name)
if ((tempfile_fd = open(tempfile_name, O_RDONLY)) == -1)
goto close_pipes_and_exit;
if (dup2(tempfile_fd, STDIN_FILENO) != STDIN_FILENO)
if (dup2(tempfile_fd, STDIN_FILENO) != STDIN_FILENO) {
close(tempfile_fd);
goto close_pipes_and_exit;
}
close(tempfile_fd);
@ -2808,7 +2810,6 @@ const char *do_int_speller(const char *tempfile_name)
close_pipes_and_exit:
/* Don't leak any handles. */
close(tempfile_fd);
close(spell_fd[0]);
close(spell_fd[1]);
close(sort_fd[0]);