mirror of
https://github.com/gentoo-mirror/gentoo.git
synced 2026-08-31 21:18:09 -07:00
06efdcb4e1
When no NVIDIA GPU is available, there are a few options:
1) Warn or silently skip tests which is unfortunate if you really want
the tests to run, and I'd say the common case is you do want that. The only time
you *don't* is in the tinderbox scenario where you're not actually using many/most/all
of the things you install.
Even if you're a user running tests because you have it installed, you likely
want the tests to run (not just developers) for that package.
We've had cases where these smart warnings or skips are broken where
we've missed out on real test coverage for no good reason. A recent
example is d3f2238d41.
2) Fail hard if it's not accessible, which may mean there's no such GPU at all,
or just that there's missing permissions. The only case this seems to inconvenience
is tinderboxes, which seems like an acceptable trade-off here.
Note that userpriv is still seemingly an issue even w/ the portage user
being in the video group but maybe I'm missing something there as I'm
a little surprised by that.
Bug: https://bugs.gentoo.org/516572
Closes: https://bugs.gentoo.org/981024
Signed-off-by: Sam James <sam@gentoo.org>