mirror of
https://github.com/gentoo-mirror/gentoo.git
synced 2026-08-06 12:58:16 -07:00
56bd759df1
This commit represents a new era for Gentoo: Storing the gentoo-x86 tree in Git, as converted from CVS. This commit is the start of the NEW history. Any historical data is intended to be grafted onto this point. Creation process: 1. Take final CVS checkout snapshot 2. Remove ALL ChangeLog* files 3. Transform all Manifests to thin 4. Remove empty Manifests 5. Convert all stale $Header$/$Id$ CVS keywords to non-expanded Git $Id$ 5.1. Do not touch files with -kb/-ko keyword flags. Signed-off-by: Robin H. Johnson <robbat2@gentoo.org> X-Thanks: Alec Warner <antarus@gentoo.org> - did the GSoC 2006 migration tests X-Thanks: Robin H. Johnson <robbat2@gentoo.org> - infra guy, herding this project X-Thanks: Nguyen Thai Ngoc Duy <pclouds@gentoo.org> - Former Gentoo developer, wrote Git features for the migration X-Thanks: Brian Harring <ferringb@gentoo.org> - wrote much python to improve cvs2svn X-Thanks: Rich Freeman <rich0@gentoo.org> - validation scripts X-Thanks: Patrick Lauer <patrick@gentoo.org> - Gentoo dev, running new 2014 work in migration X-Thanks: Michał Górny <mgorny@gentoo.org> - scripts, QA, nagging X-Thanks: All of other Gentoo developers - many ideas and lots of paint on the bikeshed
49 lines
1.8 KiB
Diff
49 lines
1.8 KiB
Diff
Avoid warnings on perl 5.20.
|
|
|
|
"Possible precedence issue with control flow operator
|
|
at Shell/EnvImporter/Result.pm line 88"
|
|
|
|
This one is due to the fact that "return ..." binds more strongly than
|
|
"and", so the function would simply "return $self->shell_status == 0",
|
|
disregarding $self->command_status and $self->env_status.
|
|
Changing "and" to "&&" solves this issue.
|
|
|
|
"Use of uninitialized value $_[1] in read at IO/Handle.pm"
|
|
|
|
This is because we don't initialize the hash "%buf" into which we read.
|
|
Initializing the relevant keys with the empty string solves this issue.
|
|
|
|
References:
|
|
* https://rt.cpan.org/Public/Bug/Display.html?id=86171
|
|
* https://github.com/gentoo-perl/g-cpan/issues/6
|
|
* https://github.com/gentoo-perl/g-cpan/issues/6
|
|
|
|
2014-10-21 Martin von Gagern
|
|
|
|
diff -ur Shell-EnvImporter-1.07/lib/Shell/EnvImporter/Result.pm Shell-EnvImporter/lib/Shell/EnvImporter/Result.pm
|
|
--- Shell-EnvImporter-1.07/lib/Shell/EnvImporter/Result.pm 2006-09-01 03:53:30.000000000 +0200
|
|
+++ Shell-EnvImporter/lib/Shell/EnvImporter/Result.pm 2014-10-21 09:34:00.814867969 +0200
|
|
@@ -84,8 +84,8 @@
|
|
###############
|
|
my $self = shift;
|
|
|
|
- return $self->shell_status == 0 and
|
|
- $self->command_status == 0 and
|
|
+ return $self->shell_status == 0 &&
|
|
+ $self->command_status == 0 &&
|
|
$self->env_status == 0;
|
|
|
|
}
|
|
diff -ur Shell-EnvImporter-1.07/lib/Shell/EnvImporter/Shell.pm Shell-EnvImporter/lib/Shell/EnvImporter/Shell.pm
|
|
--- Shell-EnvImporter-1.07/lib/Shell/EnvImporter/Shell.pm 2009-07-03 07:00:30.000000000 +0200
|
|
+++ Shell-EnvImporter/lib/Shell/EnvImporter/Shell.pm 2014-10-21 09:35:08.010881726 +0200
|
|
@@ -183,7 +183,7 @@
|
|
my $s = IO::Select->new($fh{'STDOUT'}, $fh{'STDERR'});
|
|
|
|
my $t0 = time;
|
|
- my %buf;
|
|
+ my %buf = (STDOUT => '', STDERR => '');
|
|
while (1) {
|
|
|
|
my @ready = $s->can_read();
|