Currently, there doesn't seem to be a reason to block the loading of
the unconfined policy module on the mcs and mls policy types. Let's
ensure we load the unconfined policy module unconditionally in the
eclass.
The loading of the unconfined policy module was initially blocked in
82e30f21ab, however as far as I can tell,
there is no longer a reason to do this. Considering there are use flags
for sec-policy/selinux-base and sec-policy/selinux-base-policy for the
unconfined policy module, and using the unconfined policy module is
supported for the mcs and mls policy types, it makes sense to no longer
block the loading of the policy module. It is also worth mentioning
that grabbing an selinux stage3 has the unconfined policy module
already loaded.
As the strict policy is effectively the targeted policy without support
for the unconfined domain, it makes sense to not load the unconfined
module for strict policy types. Let's keep a conitional check for the
strict policy to ensure we don't load the unconfined module in that
case.
Closes: https://bugs.gentoo.org/933709
Closes: https://github.com/gentoo/gentoo/pull/37931
Signed-off-by: Rahul Sandhu <rahul@sandhuservices.dev>
Signed-off-by: Jason Zaman <perfinion@gentoo.org>
Move applying savedconfig from src_configure() into
kernel-build_merge_configs(), in order to make it possible to override
saved config options. Previously, the saved config would
unconditionally overwrite everything, which could be between
inconvenient and plain broken (particularly if savedconfig contained
signing key paths referring to ${T}).
The new logic applies saved config via merge method, on top
of the default config along with ebuild and eclass overrides. However,
MODULES_SIGN_KEY* and user config snippets do override saved config
for convenience.
Closes: https://bugs.gentoo.org/938130
Signed-off-by: Michał Górny <mgorny@gentoo.org>
- ECM_INSTALL_ICONS and ECM_INSTALL_FILES arrays
- ecm-common_inject_heredoc() to inject custom CMake
- ECM_KCM_TARGETS to create desktop files out of json
(emulating kcmutils_generate_desktop_file)
- ecm-common-check_deps() to add additional pkg_setup checks
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
The LUA variable points to a lua binary that is likely to be executed by
the build system. Use BROOT for this.
Use ESYSROOT for the pkg-config symlink, since this is likely used for
linking a library.
Signed-off-by: Mike Gilbert <floppym@gentoo.org>
There is some more output from the compiler here.
We must use a regular expression to avoid a false positive from mold.
Acked-by: Sam James <sam@gentoo.org>
Signed-off-by: Viorel Munteanu <ceamac@gentoo.org>
This is kind of related to what Ionen mentioned at https://github.com/gentoo/gentoo/pull/28355#discussion_r1033001927
but a bit different.
Makefile rules are inconsistent, as are users, and -fuse-ld= might appear
in C{,XX}FLAGS, not just LDFLAGS.
Append -fuse-ld=bfd there too if asked to force bfd. This might
cause problems with Clang because the argument is unused. See the
mess in ddba1d149e.
Not having flag-o-matic here makes things a bit awkward. Let's try
the naive approach first because it seemed OK for me with Clang
with a quick test.
Signed-off-by: Sam James <sam@gentoo.org>
I don't think this function makes sense in a world with lld and mold.
If there's a bug causing someone to reach for tc-ld-disable-gold,
it falls into one of the following:
1. there's bfdisms (like wine where there's no hope)
=> tc-ld-force-bfd is the correct solution
2. it's a generic problem like underlinking
=> patch the package please, but in extremis or as a temporary workaround,
tc-ld-force-bfd could be used (but discouraged in this situation)
3. it's a gold bug (i.e. the package is definitely only broken with gold)
=> report the issue upstream or force bfd if the package is truly
doing something a bit unusual ("the wine case"), but really, given
gold seems to be rotting away, it doesn't appear likely any bugs
would get fixed & users shouldn't be enabling it.
I also think tc-ld-disable-gold has been used hastily in the past
for cases like 2, so let's discourage that in deprecating this as well.
Signed-off-by: Sam James <sam@gentoo.org>
For say, mold, until now tc-ld-force-bfd actually didn't work, because
it bailed early if not lld and not gold (assuming the linker was therefore bfd).
Closes: https://bugs.gentoo.org/877539
Signed-off-by: Sam James <sam@gentoo.org>
I'm starting to add various bootstrap binaries for musl, so might as
well protect all downloads of glibc only behind "elibc_glibc?" to be
safe just in case.
Signed-off-by: Arthur Zamarin <arthurzam@gentoo.org>
Dropping kde-apps/kdegraphics-mobipocket, no file collision in the first place.
Dropping kde-apps/thumbnailers after it was turned into a metapackage.
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
- detect if we are inheriting kde.org.eclass
- detect if package name is not the same as upstream name (KDE_ORG_NAME)
- iterate through "${ED}"/usr/share/metainfo/
- if file contains KDE_ORG_NAME or similar, rename that to ${PN}${SLOT/0*/}
- otherwise, prepend "${PN}${SLOT/0*/}-" after ^org.kde.
Notably, this does not (yet?) trigger if a package ${PN} == ${KDE_ORG_NAME}
but different SLOTs. Should we just do that all the time?
Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>
This is obvious in hindsight. The flags we were passing *precisely because*
we wanted e.g. -Wno-format to be passed to every test also included
-O2 or whatever from the user's flags which breaks tests that may require
no optimisation and so on.
Instead of trying to filter out options in a whack-a-mole game, let's
introduce special GCC_TESTS_* *FLAGS variables which we append
the needed -Wno-* to (etc.) which users can also specify if they really want
or need to.
Note that this isn't as scary or as weird as it sounds. We were only
trying to jam these flags in **purely** to counteract some defaults
we set, these tests really aren't supposed to be run with arbitrary
flags stuck in, but a workaround we added started to introduce way
more than intended.
The torture tests are fine with being run with various optimisation flags
but the rest of the testesuite isn't.
This fixes 361c375864 and some of the
attempts afterwards, although not everything in those commits was bad.
Fixes: 361c375864
Signed-off-by: Sam James <sam@gentoo.org>