autotools is genius software. When you add a flag called
--disable-werror, it isn't actually a flag called --disable-werror. It's
a flag called AC_ARG_ENABLE(werror), which expands "code if argument
was passed on the command line" and "code if argument was not passed on
the command line" blocks. When you say "--disable-werror" all you
actually do is add a formatted help text, which is otherwise totally
ignored by autoconf.
kvazaar had an AC_ARG_ENABLE that defined an
action-if-argument-was-defined-on-the-command-line of nothing, and an
action-if-argument-was-excluded-on-the-command-line of adding -Werror to
CFLAGS.
Back in commit 019c44a86a, this was then
used to work around the default addition of -Werror. Logical.
In the very next release, upstream changed the help text to advertise
the --enable-* form, and switched it to
action-if-argument-was-defined-on-the-command-line of adding -Werror,
action-if-argument-was-excluded-on-the-command-line of nothing.
See:
https://github.com/ultravideo/kvazaar/commit/033bc6bc45b0c6b200a4227208d2fa6263e09166
This naturally meant that passing --disable-werror would add -Werror, in
addition to setting the ignored shell variable enable_werror=no. So for
seven years, we've been building with -Werror. Yay!
During that very version bump, --disable-werror was never removed.
Instead, append-flags was used to add an additional gcc switch back off,
per the redundancy requirements of the Department of Redundancy Department's
required approach to redundantly specifying redundant flags.
This also appears to tickle edge cases in LTO due to libtool dropping
some, but not all flags... sometimes. Leading to LTO being performed
with global -Werror.
Bug: https://bugs.gentoo.org/618434
Closes: https://bugs.gentoo.org/907263
Closes: https://bugs.gentoo.org/924296
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
It was applied too late for ./configure. oops.
While we are at it, update the comment. I ended up filing a bug. Was
very iffy on doing so, but 2 days ago, upstream demonstrated signs of
life via committing an update to git:
> spelling fix in man page (from Debian; fixed by Graham Inggs; reported by Petter Reinholdtsen)
Fixes: 3e255fb3f9
Closes: https://bugs.gentoo.org/927483
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
See https://www.mail-archive.com/rsync-announce@lists.samba.org/msg00113.html.
"""
The github repos have moved to a new RsyncProject organization. Because
various life events have been monopolizing my time, I reached out to Tridge
(the original author) and he has graciously agreed to get back into rsync
work, along with Paul Mackerras, who was also an early contributor to
rsync. This new team will be working mainly on maintenance tasks, and not
so much on new features. If you want to get involved, feel free to reach
out on the new discord RsyncProject channels.
"""
Signed-off-by: Sam James <sam@gentoo.org>
* Fix USE=bzip2 not enabling bz2 plugin.
* Drop msdk plugin for now; it'll get reintroduced later as gst-plugins-msdk, plus
an alternative gst-plugins-qsv. Currently no consumers of these have been found,
as they aren't getting used automatically by playbin/encodebin yet.
* Drop transitional gtk, egl, gles2 and opengl USE flags; looks like everything has
migrated to gst-plugins-gtk and gst-plugins-base[egl,gles2,opengl] deps.
* Fix automagic dep on gudev for va plugin.
* Fix automagic x11 dep for librfb plugin (USE=vnc).
* Move vaapi handling to the common block, and add it to GST_PLUGINS_NOAUTO to make
that work.
* Drop leftover autotools era multilib_src_install_all - no libtool with meson.
* Add missing subslot dep operator for media-libs/libva
Signed-off-by: Mart Raudsepp <leio@gentoo.org>