Upstream has signed the official tarballs for like a decade. The current
SRC_URI was using github autogenerated tarballs of unknown provenance
instead...
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
Used by net-p2p/qbittorrent; signing key has been nicely stable for 8
years now.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
It was silently removed from 4.6.x as part of a bump. Really, it could
be removed since a long time ago. Upstream dropped the use of a system
geoip database waaaaaaaaaaaaaaaay back when, in:
https://github.com/qbittorrent/qBittorrent/commit/79976fbfcee4b6da2bea7d3a09db4dddceb6faaf
It has been the case since 2015 and the 3.3.0 release, at least
(possibly longer but upstream has very odd git branch habits so it's
difficult to tell).
Ever since then the dependency has simply been dead weight.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
It was silently removed from 4.6.x as part of a bump. It was *added*
long ago in commit 6b33e72d89 with the
informative and explanatory message:
> Add virtual/libiconv dep
I don't believe there's any valid justification for this. The
application makes heavy use of Qt, and that includes using Qt's string
translation features, which means it will use whatever Qt's APIs happen
to use internally. Nowhere in the source code is iconv mentioned at all.
If the virtual is needed then it is firmly in the realm of "citation
needed".
Remove it from 4.5 as well -- and the live ebuild.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
In commit 6b33e72d89, the statement
"enabling the dbus USE flag requires enabling the gui USE flag" was
dropped from the REQUIRED_USE variable, with the following reasoning:
> DBus support is only enabled when GUI is enabled.
This is semantically problematic because it means that portage *thinks*
USE="dbus -gui" produces a different binary than USE="-dbus -gui" even
though they are in reality the same.
On the flip side: unbinding these means that people who set USE="-gui"
will get a constraint violation until they also set -dbus, since it is
by default enabled. But "gui" is also default-enabled, so it just means
that users disabling one have to disable both at the same time.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
The relevant accounts are tied to use of qbittorrent-nox, the daemonized
system service with systemd/openrc service files that launch as the
created user accounts. It is totally unneeded by purely USE=gui users
(the default configuration) as that simply runs in the context of the
logged in desktop user.
While we are at it, ensure the openrc service files are only installed
for USE=webui as well. The service files attempt to run qbittorrent-nox,
and for that very reason the upstream systemd unit is only installed for
USE=webui. The openrc services stick out like a sore thumb.
Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
Matoro Mahri
Sam James
Eli Schwartz
Alexey Sokolov