From 8ff6b44d29f8bbd4b3c3970af11d0ea3aebb2ca6 Mon Sep 17 00:00:00 2001 From: Sam James Date: Mon, 18 Nov 2024 11:09:01 +0000 Subject: [PATCH] toolchain.eclass: drop -g for src_test I was seriously mistaken on this: `1 file changed, 2228 deletions(-)` when testing dropping it. -g ultimately causes many more matches because of debug statements and it confuses so many tests. I must have just made an error when testing other big test flag changes around the time. This reverts commit 7200aecb3db3b2dd91129e1530bcb75ce096af91. Signed-off-by: Sam James --- eclass/toolchain.eclass | 4 ---- 1 file changed, 4 deletions(-) diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass index deedb1867816b..f131da7dbd68a 100644 --- a/eclass/toolchain.eclass +++ b/eclass/toolchain.eclass @@ -2270,10 +2270,6 @@ toolchain_src_test() { GCC_TESTS_CFLAGS+=" -fno-stack-clash-protection" GCC_TESTS_CXXFLAGS+=" -fno-stack-clash-protection" - # configure defaults to '-O2 -g' and some tests expect it - # accordingly. - GCC_TESTS_CFLAGS+=" -g" - # TODO: Does this handle s390 (-m31) correctly? # TODO: What if there are multiple ABIs like x32 too? # XXX: Disabled until validate_failures.py can handle 'variants'