From 6952d230a11be325d68ec744cc7f8cffadbcde60 Mon Sep 17 00:00:00 2001
From: Sam James <sam@gentoo.org>
Date: Sun, 14 May 2023 01:23:30 +0100
Subject: [PATCH] dev-vcs/cssc: drop invalid USE=valgrind flag (for test suite)

We don't, in general, run Valgrind for test suites in Gentoo because it's
not portable enough and gives inconsistent results, especially under sandbox.

Plus it's confusing given USE=valgrind is effectively a global USE flag (even
if it isn't in use.desc yet) for meaning "enable annotations to enable better
debugging under Valgrind", rather than "run tests under it".

Signed-off-by: Sam James <sam@gentoo.org>
---
 dev-vcs/cssc/cssc-1.4.1.ebuild | 14 +++++++-------
 dev-vcs/cssc/metadata.xml      |  3 ---
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/dev-vcs/cssc/cssc-1.4.1.ebuild b/dev-vcs/cssc/cssc-1.4.1.ebuild
index 5be7ce4bb7ea0..3705d88715bad 100644
--- a/dev-vcs/cssc/cssc-1.4.1.ebuild
+++ b/dev-vcs/cssc/cssc-1.4.1.ebuild
@@ -1,4 +1,4 @@
-# Copyright 1999-2021 Gentoo Authors
+# Copyright 1999-2023 Gentoo Authors
 # Distributed under the terms of the GNU General Public License v2
 
 EAPI=7
@@ -13,16 +13,15 @@ HOMEPAGE="https://www.gnu.org/software/cssc/"
 SLOT="0"
 LICENSE="GPL-3"
 KEYWORDS="amd64 x86 ~amd64-linux ~x86-linux ~ppc-macos"
-
-IUSE="test valgrind"
+IUSE="test"
 RESTRICT="!test? ( test )"
-DEPEND="
-	test? ( valgrind? ( dev-util/valgrind ) )
-"
+
 DOCS=( AUTHORS ChangeLog NEWS README )
+
 PATCHES=(
 	"${FILESDIR}"/${PN}-1.4.1-m4.patch
 )
+
 S=${WORKDIR}/${CSSC_P}
 
 src_prepare() {
@@ -31,8 +30,9 @@ src_prepare() {
 }
 
 src_configure() {
+	# Valgrind is only used for tests
 	econf \
-		$(use test && use_with valgrind) \
+		--disable-valgrind \
 		--enable-binary
 }
 
diff --git a/dev-vcs/cssc/metadata.xml b/dev-vcs/cssc/metadata.xml
index a5c17692a105b..6660c03dfea07 100644
--- a/dev-vcs/cssc/metadata.xml
+++ b/dev-vcs/cssc/metadata.xml
@@ -2,9 +2,6 @@
 <!DOCTYPE pkgmetadata SYSTEM "https://www.gentoo.org/dtd/metadata.dtd">
 <pkgmetadata>
   <!-- maintainer-needed -->
-  <use>
-    <flag name="valgrind">Enable usage of <pkg>dev-util/valgrind</pkg> in tests</flag>
-  </use>
   <upstream>
     <remote-id type="savannah">cssc</remote-id>
   </upstream>