From 031e152dafaa74c07068f677c853b71b5f350ec1 Mon Sep 17 00:00:00 2001 From: Sam James Date: Sun, 14 May 2023 01:19:34 +0100 Subject: [PATCH] media-libs/vigra: drop invalid USE=valgrind flag (for test suite) We don't, in general, run Valgrind for test suites in Gentoo because it's not portable enough and gives inconsistent results, especially under sandbox. Plus it's confusing given USE=valgrind is effectively a global USE flag (even if it isn't in use.desc yet) for meaning "enable annotations to enable better debugging under Valgrind", rather than "run tests under it". Signed-off-by: Sam James --- media-libs/vigra/metadata.xml | 3 --- media-libs/vigra/vigra-1.11.1-r8.ebuild | 5 ++--- media-libs/vigra/vigra-1.11.1-r9.ebuild | 5 ++--- media-libs/vigra/vigra-9999.ebuild | 5 ++--- 4 files changed, 6 insertions(+), 12 deletions(-) diff --git a/media-libs/vigra/metadata.xml b/media-libs/vigra/metadata.xml index 14449893ddbe6..42f024b353cf3 100644 --- a/media-libs/vigra/metadata.xml +++ b/media-libs/vigra/metadata.xml @@ -5,9 +5,6 @@ printing@gentoo.org Gentoo Printing Project - - Enable valgrind in make check - ukoethe/vigra diff --git a/media-libs/vigra/vigra-1.11.1-r8.ebuild b/media-libs/vigra/vigra-1.11.1-r8.ebuild index 2c819e9075737..8e05bebbabd40 100644 --- a/media-libs/vigra/vigra-1.11.1-r8.ebuild +++ b/media-libs/vigra/vigra-1.11.1-r8.ebuild @@ -20,7 +20,7 @@ fi LICENSE="MIT" SLOT="0" -IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff valgrind +zlib" +IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff +zlib" REQUIRED_USE=" python? ( hdf5 ${PYTHON_REQUIRED_USE} ) @@ -29,7 +29,6 @@ REQUIRED_USE=" BDEPEND=" test? ( >=dev-python/nose-1.1.2-r1[${PYTHON_USEDEP}] - valgrind? ( dev-util/valgrind ) ) " # runtime dependency on python is required by the vigra-config script @@ -113,7 +112,7 @@ src_configure() { -DDOCINSTALL="share/doc/${PF}/html" -DWITH_HDF5=$(usex hdf5) -DWITH_OPENEXR=$(usex openexr) - -DWITH_VALGRIND=$(usex valgrind) + -DWITH_VALGRIND=OFF # only used for tests -DWITH_VIGRANUMPY=$(usex python) ) cmake_src_configure diff --git a/media-libs/vigra/vigra-1.11.1-r9.ebuild b/media-libs/vigra/vigra-1.11.1-r9.ebuild index beb3622e9ca07..ef5236cfe1b78 100644 --- a/media-libs/vigra/vigra-1.11.1-r9.ebuild +++ b/media-libs/vigra/vigra-1.11.1-r9.ebuild @@ -20,7 +20,7 @@ fi LICENSE="MIT" SLOT="0" -IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff valgrind +zlib" +IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff +zlib" REQUIRED_USE=" python? ( hdf5 ${PYTHON_REQUIRED_USE} ) @@ -29,7 +29,6 @@ REQUIRED_USE=" BDEPEND=" test? ( >=dev-python/nose-1.1.2-r1[${PYTHON_USEDEP}] - valgrind? ( dev-util/valgrind ) ) " # runtime dependency on python is required by the vigra-config script @@ -114,7 +113,7 @@ src_configure() { -DDOCINSTALL="share/doc/${PF}/html" -DWITH_HDF5=$(usex hdf5) -DWITH_OPENEXR=$(usex openexr) - -DWITH_VALGRIND=$(usex valgrind) + -DWITH_VALGRIND=OFF # only used for tests -DWITH_VIGRANUMPY=$(usex python) ) cmake_src_configure diff --git a/media-libs/vigra/vigra-9999.ebuild b/media-libs/vigra/vigra-9999.ebuild index 9d414e9529c7c..5a2feab44ca90 100644 --- a/media-libs/vigra/vigra-9999.ebuild +++ b/media-libs/vigra/vigra-9999.ebuild @@ -20,7 +20,7 @@ fi LICENSE="MIT" SLOT="0" -IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff valgrind +zlib" +IUSE="doc +fftw +hdf5 +jpeg mpi openexr +png +python test +tiff +zlib" REQUIRED_USE=" python? ( hdf5 ${PYTHON_REQUIRED_USE} ) @@ -29,7 +29,6 @@ REQUIRED_USE=" BDEPEND=" test? ( >=dev-python/nose-1.1.2-r1[${PYTHON_USEDEP}] - valgrind? ( dev-util/valgrind ) ) " # runtime dependency on python is required by the vigra-config script @@ -107,7 +106,7 @@ src_configure() { -DDOCINSTALL="share/doc/${PF}/html" -DWITH_HDF5=$(usex hdf5) -DWITH_OPENEXR=$(usex openexr) - -DWITH_VALGRIND=$(usex valgrind) + -DWITH_VALGRIND=OFF # only used for tests -DWITH_VIGRANUMPY=$(usex python) ) cmake_src_configure