4c78a50dcf
On ZFS `copy_file_range()` and `sendfile()` fail for some reason, so add `EINVAL` to the list of error codes for which the code will fall back to a slower implementation. While we are at it, add all the error codes from https://go.dev/src/internal/poll/copy_file_range_linux.go for different filesystems and older kernel versions to the list of error codes from `copy_file_range()`. Without this, the cache defragmentation and the test testing it (`test_disk_cache`) fail with the error message "Failed to copy data to new disk cache file during defrag: Invalid argument" when the cache directory is stored on ZFS. Perhaps this is caused by me running ZFS 2.1.2 on Linux 5.16.0, which is not a supported combination. This ZFS version is only "compatible with 3.10 - 5.15 kernels" according to the release notes. Or maybe it's just not implemented. To reproduce the problem, execute `KITTY_CACHE_DIRECTORY=/path/to/zfs python3 test.py` with `KITTY_CACHE_DIRECTORY` pointing to a directory on ZFS.
125 lines
3.6 KiB
C
125 lines
3.6 KiB
C
/*
|
|
* fast-file-copy.c
|
|
* Copyright (C) 2021 Kovid Goyal <kovid at kovidgoyal.net>
|
|
*
|
|
* Distributed under terms of the GPL3 license.
|
|
*/
|
|
|
|
#if __linux__
|
|
#define _GNU_SOURCE 1
|
|
#endif
|
|
#include "fast-file-copy.h"
|
|
#if __linux__
|
|
#define HAS_SENDFILE
|
|
#include <sys/sendfile.h>
|
|
#include <unistd.h>
|
|
#endif
|
|
|
|
static bool
|
|
copy_with_buffer(int infd, int outfd, off_t in_pos, size_t len, FastFileCopyBuffer *fcb) {
|
|
if (!fcb->buf) {
|
|
fcb->sz = 32 * 1024;
|
|
fcb->buf = malloc(fcb->sz);
|
|
if (!fcb->buf) return false;
|
|
}
|
|
while (len) {
|
|
ssize_t amt_read = pread(infd, fcb->buf, MIN(len, fcb->sz), in_pos);
|
|
if (amt_read < 0) {
|
|
if (errno == EINTR || errno == EAGAIN) continue;
|
|
return false;
|
|
}
|
|
if (amt_read == 0) {
|
|
errno = EIO;
|
|
return false;
|
|
}
|
|
len -= amt_read;
|
|
in_pos += amt_read;
|
|
uint8_t *p = fcb->buf;
|
|
while(amt_read) {
|
|
ssize_t amt_written = write(outfd, p, amt_read);
|
|
if (amt_written < 0) {
|
|
if (errno == EINTR || errno == EAGAIN) continue;
|
|
return false;
|
|
}
|
|
if (amt_written == 0) {
|
|
errno = EIO;
|
|
return false;
|
|
}
|
|
amt_read -= amt_written;
|
|
p += amt_written;
|
|
}
|
|
}
|
|
return true;
|
|
}
|
|
|
|
#ifdef HAS_SENDFILE
|
|
static bool
|
|
copy_with_sendfile(int infd, int outfd, off_t in_pos, size_t len, FastFileCopyBuffer *fcb) {
|
|
unsigned num_of_consecutive_zero_returns = 128;
|
|
while (len) {
|
|
off_t r = in_pos;
|
|
ssize_t n = sendfile(outfd, infd, &r, len);
|
|
if (n < 0) {
|
|
if (errno == EAGAIN) continue;
|
|
if (errno == ENOSYS || // No kernel support
|
|
errno == EPERM ||
|
|
errno == EINVAL) // ZFS for some reason
|
|
return copy_with_buffer(infd, outfd, in_pos, len, fcb);
|
|
return false;
|
|
}
|
|
if (n == 0) {
|
|
// happens if input file is truncated
|
|
if (!--num_of_consecutive_zero_returns) return false;
|
|
continue;
|
|
};
|
|
num_of_consecutive_zero_returns = 128;
|
|
in_pos += n; len -= n;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
static bool
|
|
copy_with_file_range(int infd, int outfd, off_t in_pos, size_t len, FastFileCopyBuffer *fcb) {
|
|
#ifdef HAS_COPY_FILE_RANGE
|
|
unsigned num_of_consecutive_zero_returns = 128;
|
|
while (len) {
|
|
off64_t r = in_pos;
|
|
ssize_t n = copy_file_range(infd, &r, outfd, NULL, len, 0);
|
|
if (n < 0) {
|
|
if (errno == EAGAIN) continue;
|
|
if (errno == ENOSYS || // Linux < 4.5
|
|
errno == EPERM || // Possibly Docker
|
|
errno == EINVAL || // ZFS for some reason
|
|
errno == EIO || // CIFS
|
|
errno == EOPNOTSUPP || // NFS
|
|
errno == EXDEV) // Prior to Linux 5.3, it was not possible to copy_file_range across file systems
|
|
return copy_with_sendfile(infd, outfd, in_pos, len, fcb);
|
|
return false;
|
|
}
|
|
if (n == 0) {
|
|
// happens if input file is truncated
|
|
if (!--num_of_consecutive_zero_returns) return false;
|
|
continue;
|
|
};
|
|
num_of_consecutive_zero_returns = 128;
|
|
in_pos += n; len -= n;
|
|
}
|
|
return true;
|
|
#else
|
|
return copy_with_sendfile(infd, outfd, in_pos, len, fcb);
|
|
#endif
|
|
}
|
|
|
|
|
|
#endif
|
|
|
|
bool
|
|
copy_between_files(int infd, int outfd, off_t in_pos, size_t len, FastFileCopyBuffer *fcb) {
|
|
#ifdef HAS_SENDFILE
|
|
return copy_with_file_range(infd, outfd, in_pos, len, fcb);
|
|
#else
|
|
return copy_with_buffer(infd, outfd, in_pos, len, fcb);
|
|
#endif
|
|
return true;
|
|
}
|