Kovid Goyal
2151969ae5
IBUS: Hide the pre-edit text when receiving a HidePreeditText message
2022-01-26 10:12:48 +05:30
Kovid Goyal
02e1272502
Slightly improve debug text
2022-01-23 20:40:41 +05:30
pagedown
b2d0c35fc2
Clear the pre-edit text only when inserting non-control characters
...
Maintains the pre-edit input state after pressing the modifier key
combination or function key while using the IME.
2022-01-23 22:22:24 +08:00
pagedown
3ee12082f2
No need to update the pre-edit text
2022-01-23 22:16:26 +08:00
pagedown
1ce4fc9c8c
Check for ASCII control chars before sending text
2022-01-23 21:40:27 +08:00
pagedown
57e2866b68
macOS: Fix caps_lock not clearing pre-edit text when using IME
2022-01-23 18:50:55 +08:00
pagedown
195fc1a270
Minor tweaks to macOS key event debug log
2022-01-23 18:45:18 +08:00
Kovid Goyal
39e56f1864
Dont check the return value of handleEvent
...
It's apparently meaningless, despite what the docs say
2022-01-23 12:47:29 +05:30
Kovid Goyal
053bb999d3
Merge branch 'fix-macos-ime-modifiers' of https://github.com/page-down/kitty
2022-01-23 10:41:45 +05:30
pagedown
83884f42f8
macOS: Fix text insertion by modifier keys when using IME
2022-01-23 01:50:37 +08:00
pagedown
fbaf3e2f49
Update preedit text with markedText
...
This fixes the preedit text being cleared when using shortcut keys to
switch candidate text in the input state.
2022-01-23 00:01:08 +08:00
Kovid Goyal
c0be0f74d8
Use commit text instead of a zero key event
...
Thanks @page-down
2022-01-22 21:11:26 +05:30
Kovid Goyal
688a3eaef7
Check if input context handles flagschanged event
2022-01-22 16:17:01 +05:30
Kovid Goyal
3b15b46d08
Also deal with setMarkedText called from event loop with actual marked text
2022-01-22 16:13:44 +05:30
Kovid Goyal
f21ddae94f
Handle setMarkedText called from the event loop
...
Also pass through text with zero key
2022-01-22 16:08:50 +05:30
Kovid Goyal
cd9b752926
...
2022-01-22 16:02:05 +05:30
Kovid Goyal
655a5a2808
Handle insertText called from the event loop by the text input system
2022-01-22 15:51:43 +05:30
Kovid Goyal
3867620be5
...
2022-01-22 14:58:10 +05:30
Kovid Goyal
03a7361325
Some debug prints for flagsChanged
2022-01-22 14:57:13 +05:30
Kovid Goyal
e8c683db8b
A new approach to handling flagsChanged with IME
...
Bypass cocoa's flagsChanged handling and call handleevent ourselves,
this allows us to know exactly what the IME is doing. Hopefully fixes
issues with IMEs that change state on modifier key presses.
Fixes #4541
2022-01-22 14:47:57 +05:30
Kovid Goyal
1f4372b34c
Test if text is being inserted rather than if text is present
2022-01-20 11:16:05 +05:30
Kovid Goyal
b090602fdb
macOS: Fix the shift key not clearing pre-edit text in IME
...
Fixes #4541
2022-01-20 08:00:17 +05:30
Kovid Goyal
16d3e82515
Add debug output when ignoring key press during IME
2022-01-19 14:50:12 +05:30
Kovid Goyal
21bc5bf8c0
Dont leak a reference to input_source_at_last_key_event
2022-01-19 12:06:54 +05:30
pagedown
5182f79152
macOS: Fix global shortcuts with shift modifier key not working
2022-01-17 02:23:00 +08:00
Kovid Goyal
06ff685f8e
oops
2022-01-15 14:54:30 +05:30
Kovid Goyal
c6ecdf0fa4
Ensure ignoreOSKeyboardProcessing is initialized
2022-01-15 14:43:10 +05:30
Kovid Goyal
ca4840717b
macOS: Fix using shortcuts from the global menu bar as subsequent key presses in a multi key mapping not working
...
Fixes #4519
2022-01-15 13:56:18 +05:30
Kovid Goyal
c473df4393
Ignore NSEventModifierFlagFunction when parsing global shortcuts
2022-01-15 12:16:18 +05:30
Kovid Goyal
aab121b35d
Also check for shiftable shortcuts in the virtual key code case
2022-01-15 10:23:18 +05:30
Kovid Goyal
396906860d
macOS: When checking for global shortcuts handle shifted form of cmd+`
2022-01-15 10:14:06 +05:30
Kovid Goyal
3a0d8ada6a
Merge branch 'feat-macos-kbd-shortcuts' of https://github.com/page-down/kitty
2022-01-14 12:36:01 +05:30
pagedown
704487f0ce
macOS: Release input context
2022-01-14 14:18:03 +08:00
pagedown
a9bdf70275
macOS: Watch for system preferences changes and update global_shortcuts
2022-01-14 13:51:46 +08:00
pagedown
ab5b9fb329
macOS: Only check the "standard" type of the system shortcuts
2022-01-14 10:07:38 +08:00
pagedown
e0700d45de
macOS: Update to the latest and categorize the system shortcut names
2022-01-14 10:05:49 +08:00
Kovid Goyal
0a89fe2e17
Merge branch 'fix-macos-text-input-beep' of https://github.com/page-down/kitty
2022-01-13 20:23:23 +05:30
pagedown
5b5651ca7d
macOS: Suppress the key combinations beep sound
2022-01-13 22:51:53 +08:00
Kovid Goyal
5e5cd1acc8
Simplify flagsChanged and make it more robust
...
Now it only sends a key event to kitty if an actual modifier key was
pressed/released.
2022-01-13 20:13:55 +05:30
Kovid Goyal
79fd01093a
fix typo in generating lookup keys for vk code based shortcuts
2022-01-13 19:21:49 +05:30
Kovid Goyal
a56471f7ed
Validate the parameters array
2022-01-13 16:44:43 +05:30
Kovid Goyal
96b46c554e
Add type annotations to dictionaries
2022-01-13 16:29:13 +05:30
Kovid Goyal
a819023ab7
remove redundant cast
2022-01-13 16:05:48 +05:30
Kovid Goyal
9504f50bd4
...
2022-01-13 16:04:50 +05:30
Kovid Goyal
8fe71e3dc8
Dont use a block for dictionary enumeration
...
Maybe that will fix the mysterious issue @page-down is having
2022-01-13 16:02:29 +05:30
Kovid Goyal
34d7643bed
Ensure global_shosrtcuts is initialized
2022-01-13 15:10:19 +05:30
Kovid Goyal
682eb7d802
Log when events are ignored because no keyWindow is present
2022-01-13 14:22:52 +05:30
Kovid Goyal
f86a954131
ooops
2022-01-13 14:21:58 +05:30
Kovid Goyal
8e3f6d37d9
...
2022-01-13 14:15:39 +05:30
Kovid Goyal
2c38360ca0
Handle no keyWindow case
2022-01-13 13:43:01 +05:30