From f825345b1437deeec3b1a2f72665f95555681477 Mon Sep 17 00:00:00 2001
From: Luflosi <luflosi@luflosi.de>
Date: Thu, 15 Oct 2020 20:30:44 +0200
Subject: [PATCH] Fix potential garbage pointer dereference

`create_os_window()` calls `get_window_content_scale()` without initializing the `xscale` and `yscale` variables. Instead of initializing them everywhere, where this function is called, just do it once in the function itself.
Found with the Clang Static Analyzer.
---
 kitty/glfw.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/kitty/glfw.c b/kitty/glfw.c
index 8058ff69d..0617f551a 100644
--- a/kitty/glfw.c
+++ b/kitty/glfw.c
@@ -421,6 +421,7 @@ make_os_window_context_current(OSWindow *w) {
 
 static inline void
 get_window_content_scale(GLFWwindow *w, float *xscale, float *yscale, double *xdpi, double *ydpi) {
+    *xscale = 1; *yscale = 1;
     if (w) glfwGetWindowContentScale(w, xscale, yscale);
     else {
         GLFWmonitor *monitor = glfwGetPrimaryMonitor();
@@ -440,7 +441,7 @@ get_window_content_scale(GLFWwindow *w, float *xscale, float *yscale, double *xd
 
 static inline void
 get_window_dpi(GLFWwindow *w, double *x, double *y) {
-    float xscale = 1, yscale = 1;
+    float xscale, yscale;
     get_window_content_scale(w, &xscale, &yscale, x, y);
 }