KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix upwards selection not being cleared when lines change

Browse Source 
When selecting text by dragging upwards, the "end" of the selection is above the "start". This causes the `selection_has_screen_line()` to never return `true` in this case.
In practice this bug causes the selection to not be cleared when the screen contents under the selection change if it was made by dragging upwards.
This commit is contained in:
Luflosi 2020-10-13 21:40:03 +02:00
parent 7122ba820f
commit e2646c08a5
No known key found for this signature in database
GPG Key ID: 4E41E29EDCC345D0
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kitty/screen.c
View File

@ -373,8 +373,10 @@ selection_has_screen_line(const Selections *selections, const int y) {
for (size_t i = 0; i < selections->count; i++) { for (size_t i = 0; i < selections->count; i++) {
const Selection *s = selections->items + i; const Selection *s = selections->items + i;
if (!is_selection_empty(s)) { if (!is_selection_empty(s)) {
int top = (int)s->start.y - s->start_scrolled_by; int start = (int)s->start.y - s->start_scrolled_by;
int bottom = (int)s->end.y - s->end_scrolled_by; int end = (int)s->end.y - s->end_scrolled_by;
int top = MIN(start, end);
int bottom = MAX(start, end);
if (top <= y && y <= bottom) return true; if (top <= y && y <= bottom) return true;
} }
} }