From dcfd2b8d606184e739f6a1dd388ff8d780be1ee3 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sat, 14 Sep 2019 17:56:52 +0530 Subject: [PATCH] Fix incorrect rendering of some symbols when followed by a space while using the PowerLine font which does not have a space glyph Fixes #1225 --- docs/changelog.rst | 3 +++ kitty/fonts.c | 7 +++++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/docs/changelog.rst b/docs/changelog.rst index 3b6f12f09..debe6ab80 100644 --- a/docs/changelog.rst +++ b/docs/changelog.rst @@ -19,6 +19,9 @@ To update |kitty|, :doc:`follow the instructions `. - Allow mapping keys commonly found on European keyboards (:pull:`1928`) +- Fix incorrect rendering of some symbols when followed by a space while using + the PowerLine font which does not have a space glyph (:iss:`1225`) + 0.14.4 [2019-08-31] --------------------- diff --git a/kitty/fonts.c b/kitty/fonts.c index 8374fc8dd..801f0c0dc 100644 --- a/kitty/fonts.c +++ b/kitty/fonts.c @@ -955,8 +955,11 @@ merge_groups_for_pua_space_ligature(void) { while (G(group_idx) > 0) { Group *g = G(groups), *g1 = G(groups) + 1; g->num_cells += g1->num_cells; - g->num_glyphs += g1->num_glyphs; - g->num_glyphs = MIN(g->num_glyphs, MAX_NUM_EXTRA_GLYPHS + 1); + // We dont want the space glyphs rendered because some stupid + // fonts like PowerLine dont have a space glyph + // https://github.com/kovidgoyal/kitty/issues/1225 + /* g->num_glyphs += g1->num_glyphs; */ + /* g->num_glyphs = MIN(g->num_glyphs, MAX_NUM_EXTRA_GLYPHS + 1); */ G(group_idx)--; } }