From d66123dd1463d0f4d98754dd59813dae20e47557 Mon Sep 17 00:00:00 2001 From: Luflosi Date: Tue, 13 Aug 2019 20:56:17 +0200 Subject: [PATCH] Fix hiding the window title in macOS In b5c21632383f9ff27c13991c91c5a72187a1196a I introduced a bug where only the window title of the first OS window would be hidden. This commit fixes that bug. The bug was caused by the code hiding the window title being in an `if` statement that only executes once. --- kitty/glfw.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/kitty/glfw.c b/kitty/glfw.c index f55ebf68b..6874575c5 100644 --- a/kitty/glfw.c +++ b/kitty/glfw.c @@ -581,10 +581,6 @@ create_os_window(PyObject UNUSED *self, PyObject *args) { Py_DECREF(ret); #ifdef __APPLE__ cocoa_create_global_menu(); - if (!(OPT(macos_show_window_title_in) & WINDOW)) { - if (glfwGetCocoaWindow) cocoa_hide_window_title(glfwGetCocoaWindow(glfw_window)); - else log_error("Failed to load glfwGetCocoaWindow"); - } #endif #define CC(dest, shape) {\ if (!dest##_cursor) { \ @@ -641,8 +637,12 @@ create_os_window(PyObject UNUSED *self, PyObject *args) { glfwSetKeyboardCallback(glfw_window, key_callback); glfwSetDropCallback(glfw_window, drop_callback); #ifdef __APPLE__ - if (glfwGetCocoaWindow) cocoa_make_window_resizable(glfwGetCocoaWindow(glfw_window), OPT(macos_window_resizable)); - else log_error("Failed to load glfwGetCocoaWindow"); + if (glfwGetCocoaWindow) { + if (!(OPT(macos_show_window_title_in) & WINDOW)) { + cocoa_hide_window_title(glfwGetCocoaWindow(glfw_window)); + } + cocoa_make_window_resizable(glfwGetCocoaWindow(glfw_window), OPT(macos_window_resizable)); + } else log_error("Failed to load glfwGetCocoaWindow"); #endif double now = monotonic(); w->is_focused = true;