From d5490475f13179111fd336c329a73aeed9ef8f56 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 20 Mar 2019 08:38:35 +0530 Subject: [PATCH] Nicer error message when contacting GitHub to check for latest release fails --- docs/installer.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/docs/installer.py b/docs/installer.py index d65383869..4ef41c631 100644 --- a/docs/installer.py +++ b/docs/installer.py @@ -72,7 +72,10 @@ class Reporter: # {{{ def get_latest_release_data(): print('Checking for latest release on GitHub...') req = urllib.Request('https://api.github.com/repos/kovidgoyal/kitty/releases/latest', headers={'Accept': 'application/vnd.github.v3+json'}) - res = urllib.urlopen(req).read().decode('utf-8') + try: + res = urllib.urlopen(req).read().decode('utf-8') + except Exception as err: + raise SystemExit('Failed to contact {} with error: {}'.format(req.get_full_url(), err)) data = json.loads(res) html_url = data['html_url'].replace('/tag/', '/download/').rstrip('/') for asset in data.get('assets', ()):