macOS: Add global menu action to detach current tab

kitty/child-monitor.c

@@ -985,6 +985,7 @@ process_global_state(void *data) {
             if (cocoa_pending_actions & NEW_TAB) { call_boss(new_tab, NULL); }
             if (cocoa_pending_actions & NEXT_TAB) { call_boss(next_tab, NULL); }
             if (cocoa_pending_actions & PREVIOUS_TAB) { call_boss(previous_tab, NULL); }
+            if (cocoa_pending_actions & DETACH_TAB) { call_boss(detach_tab, NULL); }
             if (cocoa_pending_actions_wd) {
                 if (cocoa_pending_actions & NEW_OS_WINDOW_WITH_WD) { call_boss(new_os_window_with_wd, "s", cocoa_pending_actions_wd); }
                 if (cocoa_pending_actions & NEW_TAB_WITH_WD) { call_boss(new_tab_with_wd, "s", cocoa_pending_actions_wd); }

kitty/cocoa_window.m

@@ -75,48 +75,25 @@ find_app_name(void) {
 + (GlobalMenuTarget *) shared_instance;
 @end
 
+#define PENDING(selector, which) - (void)selector:(id)sender { (void)sender; set_cocoa_pending_action(which, NULL); }
+
 @implementation GlobalMenuTarget
 
-- (void)edit_config_file:(id)sender {
+PENDING(edit_config_file, PREFERENCES_WINDOW)
-    (void)sender;
+PENDING(new_os_window, NEW_OS_WINDOW)
-    set_cocoa_pending_action(PREFERENCES_WINDOW, NULL);
+PENDING(detach_tab, DETACH_TAB)
-}
+PENDING(close_os_window, CLOSE_OS_WINDOW)
-
+PENDING(close_tab, CLOSE_TAB)
-- (void)new_os_window:(id)sender {
+PENDING(new_tab, NEW_TAB)
-    (void)sender;
+PENDING(next_tab, NEXT_TAB)
-    set_cocoa_pending_action(NEW_OS_WINDOW, NULL);
+PENDING(previous_tab, PREVIOUS_TAB)
-}
-
-- (void) close_os_window:(id)sender {
-    (void)sender;
-    set_cocoa_pending_action(CLOSE_OS_WINDOW, NULL);
-}
-
-- (void)close_tab:(id)sender {
-    (void)sender;
-    set_cocoa_pending_action(CLOSE_TAB, NULL);
-}
-
-- (void)new_tab:(id)sender {
-    (void)sender;
-    set_cocoa_pending_action(NEW_TAB, NULL);
-}
-
-- (void)next_tab:(id)sender {
-    (void)sender;
-    set_cocoa_pending_action(NEXT_TAB, NULL);
-}
-
-- (void)previous_tab:(id)sender {
-    (void)sender;
-    set_cocoa_pending_action(PREVIOUS_TAB, NULL);
-}
 
 - (void)open_kitty_website_url:(id)sender {
     (void)sender;
     [[NSWorkspace sharedWorkspace] openURL:[NSURL URLWithString:@"https://sw.kovidgoyal.net/kitty/"]];
 }
 
+#undef PENDING
 
 + (GlobalMenuTarget *) shared_instance
 {
@@ -448,6 +425,9 @@ cocoa_create_global_menu(void) {
     MENU_ITEM(windowMenu, @"Show Next Tab", next_tab);
     MENU_ITEM(windowMenu, @"Close Tab", close_tab);
     MENU_ITEM(windowMenu, @"Close OS Window", close_os_window);
+    [[windowMenu addItemWithTitle:@"Move Tab to New Window"
+                           action:@selector(detach_tab:)
+                    keyEquivalent:@""] setTarget:global_menu_target];
 
     [windowMenu addItem:[NSMenuItem separatorItem]];
     [[windowMenu addItemWithTitle:@"Enter Full Screen"

kitty/state.h

@@ -269,7 +269,8 @@ typedef enum {
     CLOSE_TAB = 32,
     NEW_TAB = 64,
     NEXT_TAB = 128,
-    PREVIOUS_TAB = 256
+    PREVIOUS_TAB = 256,
+    DETACH_TAB = 512,
 } CocoaPendingAction;
 void set_cocoa_pending_action(CocoaPendingAction action, const char*);
 #endif