KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Do not allow reloading the config to affect allow_remote_control

Browse Source
This commit is contained in:
Kovid Goyal 2021-08-08 15:34:34 +05:30
parent ba9adc127e
commit c838cb03c9
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
kitty/boss.py
View File

@ -162,7 +162,10 @@ class Boss:
talk_fd = getattr(single_instance, 'socket', None) talk_fd = getattr(single_instance, 'socket', None)
talk_fd = -1 if talk_fd is None else talk_fd.fileno() talk_fd = -1 if talk_fd is None else talk_fd.fileno()
listen_fd = -1 listen_fd = -1
if args.listen_on and (opts.allow_remote_control in ('y', 'socket-only')): # we dont allow reloading the config file to change
# allow_remote_control
self.allow_remote_control = opts.allow_remote_control
if args.listen_on and (self.allow_remote_control in ('y', 'socket-only')):
listen_fd = listen_on(args.listen_on) listen_fd = listen_on(args.listen_on)
self.child_monitor = ChildMonitor( self.child_monitor = ChildMonitor(
self.on_child_death, self.on_child_death,
@ -362,7 +365,7 @@ class Boss:
from .remote_control import handle_cmd from .remote_control import handle_cmd
response = None response = None
window = window or None window = window or None
if get_options().allow_remote_control == 'y' or from_peer or getattr(window, 'allow_remote_control', False): if self.allow_remote_control == 'y' or from_peer or getattr(window, 'allow_remote_control', False):
try: try:
response = handle_cmd(self, window, cmd) response = handle_cmd(self, window, cmd)
except Exception as err: except Exception as err:

3
kitty/options/definition.py
View File

@ -2470,8 +2470,7 @@ running within kitty to control it, with :code:`yes` or only programs that
connect to the socket specified with the :option:`kitty --listen-on` command connect to the socket specified with the :option:`kitty --listen-on` command
line option, if you use the value :code:`socket-only`. The latter is useful if line option, if you use the value :code:`socket-only`. The latter is useful if
you want to prevent programs running on a remote computer over ssh from you want to prevent programs running on a remote computer over ssh from
controlling kitty. Changing this option by reloading the config will only affect controlling kitty. Reloading the config will not affect this setting.
newly created windows.
''' '''
) )