KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix read overflow reported by ASAN

Browse Source
This commit is contained in:
Kovid Goyal 2020-08-27 22:00:05 +05:30
parent 00ea189074
commit c19906eb87
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
kitty/hyperlink.c
View File

@ -101,7 +101,10 @@ get_id_for_hyperlink(Screen *screen, const char *id, const char *url) {
if (!url) return 0; if (!url) return 0;
HyperLinkPool *pool = (HyperLinkPool*)screen->hyperlink_pool; HyperLinkPool *pool = (HyperLinkPool*)screen->hyperlink_pool;
static char key[MAX_KEY_LEN] = {0}; static char key[MAX_KEY_LEN] = {0};
size_t keylen = snprintf(key, MAX_KEY_LEN-1, "%.*s:%s", MAX_ID_LEN, id ? id : "", url); int keylen = snprintf(key, MAX_KEY_LEN-1, "%.*s:%s", MAX_ID_LEN, id ? id : "", url);
if (keylen < 0) keylen = strlen(key);
else keylen = MIN(keylen, MAX_KEY_LEN - 2); // snprintf returns how many chars it would have written in case of truncation
key[keylen] = 0;
HyperLinkEntry *s = NULL; HyperLinkEntry *s = NULL;
if (pool->hyperlinks) { if (pool->hyperlinks) {
HASH_FIND_STR(pool->hyperlinks, key, s); HASH_FIND_STR(pool->hyperlinks, key, s);