KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use commit text instead of a zero key event

Browse Source 
Thanks @page-down
This commit is contained in:
Kovid Goyal 2022-01-22 21:11:26 +05:30
parent a9e014226e
commit c0be0f74d8
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glfw/cocoa_window.m
View File

@ -1481,7 +1481,7 @@ void _glfwPlatformUpdateIMEState(_GLFWwindow *w, const GLFWIMEUpdateEvent *ev) {
_glfw.ns.text[sizeof(_glfw.ns.text) - 1] = 0; _glfw.ns.text[sizeof(_glfw.ns.text) - 1] = 0;
if (!in_key_handler && _glfw.ns.text[0]) { if (!in_key_handler && _glfw.ns.text[0]) {
debug_key("sending text to kitty from insertText called from event loop: %s\n", _glfw.ns.text); debug_key("sending text to kitty from insertText called from event loop: %s\n", _glfw.ns.text);
GLFWkeyevent glfw_keyevent = {.text=_glfw.ns.text}; GLFWkeyevent glfw_keyevent = {.text=_glfw.ns.text, .ime_state=GLFW_IME_COMMIT_TEXT};
_glfwInputKeyboard(window, &glfw_keyevent); _glfwInputKeyboard(window, &glfw_keyevent);
_glfw.ns.text[0] = 0; _glfw.ns.text[0] = 0;
} }

6
kitty/keys.c
View File

@ -152,12 +152,6 @@ on_key_input(GLFWkeyevent *ev) {
debug("invalid state, ignoring\n"); debug("invalid state, ignoring\n");
return; return;
} }
if (!native_key && !key && text[0]) {
// key == 0 is sent by the glfw coca backend when text is inserted by the IME outside the key handlers
schedule_write_to_child(w->id, 1, text, strlen(text));
debug("sent key as text to child\n");
return;
}
PyObject *ke = NULL; PyObject *ke = NULL;
#define create_key_event() { ke = convert_glfw_key_event_to_python(ev); if (!ke) { PyErr_Print(); return; } } #define create_key_event() { ke = convert_glfw_key_event_to_python(ev); if (!ke) { PyErr_Print(); return; } }
if (global_state.in_sequence_mode) { if (global_state.in_sequence_mode) {