KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Stop setting title to ";" when 0-length OSC 2 is received

Browse Source 
Various programs send a 0-length title if no title is configured (e.g.,
(n)vim with 'title' unset, or mutt without ts_enabled).  When this
happens, kitty is mis-parsing the data and setting the title to ";".
This commit is contained in:
James McCoy 2018-03-26 21:30:45 -04:00
parent 90cc785b55
commit a467e79144
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
kitty/parser.c
View File

@ -310,7 +310,7 @@ dispatch_osc(Screen *screen, PyObject DUMP_UNUSED *dump_callback) {
} }
if (i > 0) { if (i > 0) {
code = utoi(screen->parser_buf, i); code = utoi(screen->parser_buf, i);
if (i < limit - 1 && screen->parser_buf[i] == ';') i++; if (i < limit && screen->parser_buf[i] == ';') i++;
} }
PyObject *string = PyUnicode_FromKindAndData(PyUnicode_4BYTE_KIND, screen->parser_buf + i, limit - i); PyObject *string = PyUnicode_FromKindAndData(PyUnicode_4BYTE_KIND, screen->parser_buf + i, limit - i);
if (string != NULL) { if (string != NULL) {

3
kitty_tests/parser.py
View File

@ -182,6 +182,9 @@ class TestParser(BaseTest):
c.clear() c.clear()
pb('\033]2;;;;\x07', ('set_title', ';;;')) pb('\033]2;;;;\x07', ('set_title', ';;;'))
self.ae(c.titlebuf, ';;;') self.ae(c.titlebuf, ';;;')
c.clear()
pb('\033]2;\x07', ('set_title', ''))
self.ae(c.titlebuf, '')
pb('\033]110\x07', ('set_dynamic_color', 110, '')) pb('\033]110\x07', ('set_dynamic_color', 110, ''))
self.ae(c.colorbuf, '') self.ae(c.colorbuf, '')