KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Avoid creating lots of newline string objects in pagerhist

Browse Source
This commit is contained in:
Kovid Goyal 2018-11-19 12:11:04 +05:30
parent db1e48848d
commit a32ed5ae5f
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
kitty/history.c
View File

@ -312,6 +312,8 @@ pagerhist_as_text(HistoryBuf *self, PyObject *callback) {
if (!ph) Py_RETURN_NONE;
if (ph->rewrap_needed) pagerhist_rewrap(ph, self->xnum);
PyObject *nl = PyUnicode_FromString("\n");
if (!nl) return NULL;
for (int i = 0; i < 3; i++) {
switch(i) {
@ -327,7 +329,8 @@ pagerhist_as_text(HistoryBuf *self, PyObject *callback) {
break;
case 2:
{ Line l = {.xnum=self->xnum}; get_line(self, 0, &l); if (l.continued) continue; }
t = PyUnicode_FromString("\n");
t = nl;
Py_INCREF(t);
break;
}
if (t == NULL) goto end;
@ -338,6 +341,7 @@ pagerhist_as_text(HistoryBuf *self, PyObject *callback) {
}
end:
Py_DECREF(nl);
if (PyErr_Occurred()) return NULL;
Py_RETURN_NONE;
}