KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix Clang warning

Browse Source 
Without this, kitty fails to compile:
```
glfw/cocoa_init.m:462:14: error: case value not in enumerated type
      'NSEventModifierFlags' (aka 'enum NSEventModifierFlags')
      [-Werror,-Wswitch]
        case (NSEventModifierFlagShift | NSEventModifierFlagOption):
             ^
glfw/cocoa_init.m:465:14: error: case value not in enumerated type
      'NSEventModifierFlags' (aka 'enum NSEventModifierFlags')
      [-Werror,-Wswitch]
        case (NSEventModifierFlagShift | NSEventModifierFlagCommand):
             ^
```
I thought about changing the type of the `modifierFlags` function parameter from `NSEventModifierFlags` to `NSUInteger` since `NSEventModifierFlags` is defined as an enum according to https://developer.apple.com/documentation/appkit/nseventmodifierflags?language=objc and is technically not the proper type for a bit field. But since Apple themselves define `modifierFlags` as `NSEventModifierFlags` according to https://developer.apple.com/documentation/appkit/nsevent/1534405-modifierflags?language=objc, I think the fix in this commit is better.
This warning was introduced with commit f9944e614088c4977ad9c9f1d1b44d97643e8d5b.
This commit is contained in:
Luflosi 2021-10-30 16:13:33 +02:00
parent d03f4dbc98
commit a1d24028b8
No known key found for this signature in database
GPG Key ID: 4E41E29EDCC345D0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
glfw/cocoa_init.m
View File

@ -455,7 +455,7 @@ void* _glfwLoadLocalVulkanLoaderNS(void)
static bool static bool
is_modified_tab(NSEvent *event, NSEventModifierFlags modifierFlags) { is_modified_tab(NSEvent *event, NSEventModifierFlags modifierFlags) {
switch (modifierFlags) { switch ((NSUInteger)modifierFlags) {
// No need to handle shift+tab, [shift]+option+tab // No need to handle shift+tab, [shift]+option+tab
case NSEventModifierFlagShift: case NSEventModifierFlagShift:
case NSEventModifierFlagOption: case NSEventModifierFlagOption: