KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix index_selection() not updating empty selections

Browse Source 
Newly created selections are empty but must still be indexed.
Fixes #3431
This commit is contained in:
Kovid Goyal 2021-04-03 10:48:43 +05:30
parent b5ac06e652
commit a13f815591
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 17 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
kitty/screen.c
View File

@ -222,26 +222,24 @@ static inline void
index_selection(const Screen *self, Selections *selections, bool up) { index_selection(const Screen *self, Selections *selections, bool up) {
for (size_t i = 0; i < selections->count; i++) { for (size_t i = 0; i < selections->count; i++) {
Selection *s = selections->items + i; Selection *s = selections->items + i;
if (!is_selection_empty(s)) { if (up) {
if (up) { if (s->start.y == 0) s->start_scrolled_by += 1;
if (s->start.y == 0) s->start_scrolled_by += 1; else {
else { s->start.y--;
s->start.y--; if (s->input_start.y) s->input_start.y--;
if (s->input_start.y) s->input_start.y--; if (s->input_current.y) s->input_current.y--;
if (s->input_current.y) s->input_current.y--;
}
if (s->end.y == 0) s->end_scrolled_by += 1;
else s->end.y--;
} else {
if (s->start.y >= self->lines - 1) s->start_scrolled_by -= 1;
else {
s->start.y++;
if (s->input_start.y < self->lines - 1) s->input_start.y++;
if (s->input_current.y < self->lines - 1) s->input_current.y++;
}
if (s->end.y >= self->lines - 1) s->end_scrolled_by -= 1;
else s->end.y++;
} }
if (s->end.y == 0) s->end_scrolled_by += 1;
else s->end.y--;
} else {
if (s->start.y >= self->lines - 1) s->start_scrolled_by -= 1;
else {
s->start.y++;
if (s->input_start.y < self->lines - 1) s->input_start.y++;
if (s->input_current.y < self->lines - 1) s->input_current.y++;
}
if (s->end.y >= self->lines - 1) s->end_scrolled_by -= 1;
else s->end.y++;
} }
} }
} }