From a0568334b51c701edab87a3db27827f0598af8a4 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Wed, 17 Aug 2022 06:42:51 +0530 Subject: [PATCH] Change the default for allow_remote_control back to no That way if there are any bugs in the implementation, we wont be exposing users by default. In the future after the implementation has been battle tested, we can revisit. --- kitty/options/definition.py | 7 +++---- kitty/options/types.py | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/kitty/options/definition.py b/kitty/options/definition.py index 26cbfaf86..71dc05ba4 100644 --- a/kitty/options/definition.py +++ b/kitty/options/definition.py @@ -2718,14 +2718,13 @@ that is used to check every remote control command. See :ref:`rc_custom_auth` fo Relative paths are resolved from the kitty configuration directory. ''') -opt('allow_remote_control', 'password', choices=('password', 'socket-only', 'socket', 'no', 'n', 'false', 'yes', 'y', 'true'), +opt('allow_remote_control', 'no', choices=('password', 'socket-only', 'socket', 'no', 'n', 'false', 'yes', 'y', 'true'), long_text=''' Allow other programs to control kitty. If you turn this on, other programs can control all aspects of kitty, including sending text to kitty windows, opening new windows, closing windows, reading the content of windows, etc. Note that -this even works over SSH connections. The default setting of :code:`password` -asks the user for confirmation when a remote control command is received. -The meaning of the various values are: +this even works over SSH connections. The default setting of :code:`no` +prevents any form of remote control. The meaning of the various values are: :code:`password` Remote control requests received over both the TTY device and the socket are diff --git a/kitty/options/types.py b/kitty/options/types.py index 56911fc14..919ff2455 100644 --- a/kitty/options/types.py +++ b/kitty/options/types.py @@ -469,7 +469,7 @@ class Options: active_tab_title_template: typing.Optional[str] = None allow_cloning: choices_for_allow_cloning = 'ask' allow_hyperlinks: int = 1 - allow_remote_control: choices_for_allow_remote_control = 'password' + allow_remote_control: choices_for_allow_remote_control = 'no' background: Color = Color(0, 0, 0) background_image: typing.Optional[str] = None background_image_layout: choices_for_background_image_layout = 'tiled'