Fix a regression in version 0.13.0 that caused background colors of space characters after private use unicode characters to not be respected

Fixes #1455
This commit is contained in:
Kovid Goyal 2019-03-11 20:03:58 +05:30
parent 56864cdfb7
commit a051cb9ee3
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
2 changed files with 7 additions and 4 deletions

View File

@ -87,6 +87,10 @@ To update |kitty|, :doc:`follow the instructions <binary>`.
- macOS: Fix specifying initial window size in cells not working correctly on
Retina screens (:iss:`1444`)
- Fix a regression in version 0.13.0 that caused background colors of space
characters after private use unicode characters to not be respected
(:iss:`1455`)
0.13.3 [2019-01-19]
------------------------------

View File

@ -1042,12 +1042,11 @@ render_line(FONTS_DATA_HANDLE fg_, Line *line) {
num_spaces++;
// We have a private use char followed by space(s), render it as a multi-cell ligature.
GPUCell *space_cell = line->gpu_cells + i + num_spaces;
// Ensure the space cell uses the foreground/background colors from the PUA cell.
// This is needed because there are stupid applications like
// powerline that use PUA+space with different foreground colors
// Ensure the space cell uses the foreground color from the PUA cell.
// This is needed because there are applications like
// Powerline that use PUA+space with different foreground colors
// for the space and the PUA. See for example: https://github.com/kovidgoyal/kitty/issues/467
space_cell->fg = gpu_cell->fg;
space_cell->bg = gpu_cell->bg;
space_cell->decoration_fg = gpu_cell->decoration_fg;
}
if (num_spaces) {