From 9aae31ef2f63aa4e24c5d44d7712a552f123c7d6 Mon Sep 17 00:00:00 2001 From: Jacob Wahlgren Date: Mon, 17 Dec 2018 23:53:43 +0100 Subject: [PATCH] macOS: Add "New OS Window" to dock menu Discussed in #1242. --- kitty/cocoa_window.m | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/kitty/cocoa_window.m b/kitty/cocoa_window.m index fbeb22c46..e00c55de6 100644 --- a/kitty/cocoa_window.m +++ b/kitty/cocoa_window.m @@ -12,6 +12,7 @@ #include // Needed for _NSGetProgname #include +#include #if (MAC_OS_X_VERSION_MAX_ALLOWED < 101200) #define NSWindowStyleMaskResizable NSResizableWindowMask @@ -99,6 +100,23 @@ cocoa_set_new_window_trigger(PyObject *self UNUSED, PyObject *args) { Py_RETURN_FALSE; } +// Implementation of applicationDockMenu: for the app delegate +static NSMenu * +get_dock_menu(id self UNUSED, SEL _cmd UNUSED, NSApplication *sender UNUSED) { + static NSMenu *dockMenu = nil; + + if (!dockMenu) { + GlobalMenuTarget *global_menu_target = [GlobalMenuTarget shared_instance]; + dockMenu = [[NSMenu alloc] init]; + NSMenuItem *newWindowItem = [dockMenu addItemWithTitle:@"New OS window" + action:@selector(new_os_window:) + keyEquivalent:@""]; + [newWindowItem setTarget:global_menu_target]; + } + + return dockMenu; +} + void cocoa_create_global_menu(void) { NSString* app_name = find_app_name(); @@ -183,6 +201,12 @@ cocoa_create_global_menu(void) { } [bar release]; + + class_addMethod( + object_getClass([NSApp delegate]), + @selector(applicationDockMenu:), + (IMP)get_dock_menu, + "@@:@"); } void