Code to read needed options from kitty.conf in a kitten

This commit is contained in:
Kovid Goyal 2023-02-22 16:09:26 +05:30
parent 0614c63966
commit 907a51c99c
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
4 changed files with 48 additions and 1 deletions

View File

@ -441,6 +441,7 @@ def load_ref_map() -> Dict[str, Dict[str, str]]:
def generate_constants() -> str: def generate_constants() -> str:
from kitty.options.types import Options
ref_map = load_ref_map() ref_map = load_ref_map()
dp = ", ".join(map(lambda x: f'"{serialize_as_go_string(x)}"', kc.default_pager_for_help)) dp = ", ".join(map(lambda x: f'"{serialize_as_go_string(x)}"', kc.default_pager_for_help))
return f'''\ return f'''\
@ -464,6 +465,11 @@ var CharacterKeyNameAliases = map[string]string{serialize_go_dict(character_key_
var ConfigModMap = map[string]uint16{serialize_go_dict(config_mod_map)} var ConfigModMap = map[string]uint16{serialize_go_dict(config_mod_map)}
var RefMap = map[string]string{serialize_go_dict(ref_map['ref'])} var RefMap = map[string]string{serialize_go_dict(ref_map['ref'])}
var DocTitleMap = map[string]string{serialize_go_dict(ref_map['doc'])} var DocTitleMap = map[string]string{serialize_go_dict(ref_map['doc'])}
var KittyConfigDefaults = struct {{
Term, Shell_integration string
}}{{
Term: "{Options.term}", Shell_integration: "{Options.shell_integration}",
}}
''' # }}} ''' # }}}
@ -682,7 +688,7 @@ def generate_ssh_kitten_data() -> None:
buf.write(data) buf.write(data)
size = len(data) size = len(data)
fmap[f] = pos, size fmap[f] = pos, size
mapping = ','.join(f'{name} {pos[0]} {pos[1]}' for name, pos in fmap.items()).encode('ascii') mapping = ','.join(f'{name} {pos[0]} {pos[1]}' for name, pos in sorted(fmap.items())).encode('ascii')
data = struct.pack('<I', len(fmap)) + mapping + b'\n' + buf.getvalue() data = struct.pack('<I', len(fmap)) + mapping + b'\n' + buf.getvalue()
with open(dest, 'wb') as d: with open(dest, 'wb') as d:
write_compressed_data(data, d) write_compressed_data(data, d)

View File

@ -171,6 +171,7 @@ type connection_data struct {
func run_ssh(ssh_args, server_args, found_extra_args []string) (rc int, err error) { func run_ssh(ssh_args, server_args, found_extra_args []string) (rc int, err error) {
go Data() go Data()
go RelevantKittyOpts()
cmd := append([]string{SSHExe()}, ssh_args...) cmd := append([]string{SSHExe()}, ssh_args...)
cd := connection_data{remote_args: server_args[1:]} cd := connection_data{remote_args: server_args[1:]}
hostname := server_args[0] hostname := server_args[0]

View File

@ -5,8 +5,11 @@ package ssh
import ( import (
"fmt" "fmt"
"io" "io"
"kitty"
"kitty/tools/config"
"kitty/tools/utils" "kitty/tools/utils"
"os/exec" "os/exec"
"path/filepath"
"regexp" "regexp"
"strconv" "strconv"
"strings" "strings"
@ -219,3 +222,23 @@ var GetSSHVersion = (&utils.Once[SSHVersion]{Run: func() SSHVersion {
} }
return SSHVersion{} return SSHVersion{}
}}).Get }}).Get
type KittyOpts struct {
Term, Shell_integration string
}
var RelevantKittyOpts = (&utils.Once[KittyOpts]{Run: func() KittyOpts {
ans := KittyOpts{Term: kitty.KittyConfigDefaults.Term, Shell_integration: kitty.KittyConfigDefaults.Shell_integration}
handle_line := func(key, val string) error {
switch key {
case "term":
ans.Term = strings.TrimSpace(val)
case "shell_integration":
ans.Shell_integration = strings.TrimSpace(val)
}
return nil
}
cp := config.ConfigParser{LineHandler: handle_line}
cp.ParseFiles(filepath.Join(utils.ConfigDir(), "kitty.conf"))
return ans
}}).Get

View File

@ -4,8 +4,11 @@ package ssh
import ( import (
"fmt" "fmt"
"os"
"path/filepath"
"testing" "testing"
"kitty/tools/utils"
"kitty/tools/utils/shlex" "kitty/tools/utils/shlex"
"github.com/google/go-cmp/cmp" "github.com/google/go-cmp/cmp"
@ -51,3 +54,17 @@ func TestParseSSHArgs(t *testing.T) {
p(`-46p23 -S/moose -W x:6 -- localhost sh -c "a b"`, `-4 -6 -p 23 -S /moose -W x:6`, `localhost sh -c "a b"`, ``, false) p(`-46p23 -S/moose -W x:6 -- localhost sh -c "a b"`, `-4 -6 -p 23 -S /moose -W x:6`, `localhost sh -c "a b"`, ``, false)
p(`--kitten=abc -np23 --kitten xyz host`, `-n -p 23`, `host`, `--kitten abc --kitten xyz`, true) p(`--kitten=abc -np23 --kitten xyz host`, `-n -p 23`, `host`, `--kitten abc --kitten xyz`, true)
} }
func TestRelevantKittyOpts(t *testing.T) {
tdir := t.TempDir()
orig := utils.ConfigDir
utils.ConfigDir = func() string { return tdir }
defer func() { utils.ConfigDir = orig }()
os.WriteFile(filepath.Join(tdir, "kitty.conf"), []byte("term XXX\nshell_integration changed\nterm abcd"), 0o600)
if RelevantKittyOpts().Term != "abcd" {
t.Fatalf("Unexpected TERM: %s", RelevantKittyOpts().Term)
}
if RelevantKittyOpts().Shell_integration != "changed" {
t.Fatalf("Unexpected shell_integration: %s", RelevantKittyOpts().Shell_integration)
}
}