diff --git a/glfw/cocoa_init.m b/glfw/cocoa_init.m index 29e087a13..5ae1052ff 100644 --- a/glfw/cocoa_init.m +++ b/glfw/cocoa_init.m @@ -669,8 +669,6 @@ int _glfwPlatformInit(void) if (!initializeTIS()) return false; - _glfwInitJoysticksNS(); - _glfwPollMonitorsNS(); return true; @@ -723,7 +721,6 @@ void _glfwPlatformTerminate(void) free(_glfw.ns.clipboardString); _glfwTerminateNSGL(); - _glfwTerminateJoysticksNS(); } // autoreleasepool } diff --git a/glfw/cocoa_joystick.h b/glfw/cocoa_joystick.h index ce98221ae..4775342eb 100644 --- a/glfw/cocoa_joystick.h +++ b/glfw/cocoa_joystick.h @@ -44,7 +44,3 @@ typedef struct _GLFWjoystickNS CFMutableArrayRef hats; } _GLFWjoystickNS; - -void _glfwInitJoysticksNS(void); -void _glfwTerminateJoysticksNS(void); - diff --git a/glfw/cocoa_joystick.m b/glfw/cocoa_joystick.m index 1425599d3..5049b6ebf 100644 --- a/glfw/cocoa_joystick.m +++ b/glfw/cocoa_joystick.m @@ -296,7 +296,7 @@ static void removeCallback(void* context UNUSED, // Initialize joystick interface // -void _glfwInitJoysticksNS(void) +bool _glfwPlatformInitJoysticks(void) { CFMutableArrayRef matching; const long usages[] = @@ -315,7 +315,7 @@ void _glfwInitJoysticksNS(void) if (!matching) { _glfwInputError(GLFW_PLATFORM_ERROR, "Cocoa: Failed to create array"); - return; + return false; } for (size_t i = 0; i < sizeof(usages) / sizeof(long); i++) @@ -370,19 +370,23 @@ void _glfwInitJoysticksNS(void) // Execute the run loop once in order to register any initially-attached // joysticks CFRunLoopRunInMode(kCFRunLoopDefaultMode, 0, false); + return true; } // Close all opened joystick handles // -void _glfwTerminateJoysticksNS(void) +void _glfwPlatformTerminateJoysticks(void) { int jid; for (jid = 0; jid <= GLFW_JOYSTICK_LAST; jid++) closeJoystick(_glfw.joysticks + jid); - CFRelease(_glfw.ns.hidManager); - _glfw.ns.hidManager = NULL; + if (_glfw.ns.hidManager) + { + CFRelease(_glfw.ns.hidManager); + _glfw.ns.hidManager = NULL; + } } diff --git a/glfw/init.c b/glfw/init.c index 80d1d9387..2ed62d5c1 100644 --- a/glfw/init.c +++ b/glfw/init.c @@ -92,6 +92,7 @@ static void terminate(void) _glfw.mappingCount = 0; _glfwTerminateVulkan(); + _glfwPlatformTerminateJoysticks(); _glfwPlatformTerminate(); _glfw.initialized = false; diff --git a/glfw/input.c b/glfw/input.c index a08fd1097..bc0a66d8f 100644 --- a/glfw/input.c +++ b/glfw/input.c @@ -44,6 +44,22 @@ #define _GLFW_JOYSTICK_BUTTON 2 #define _GLFW_JOYSTICK_HATBIT 3 +// Initializes the platform joystick API if it has not been already +// +static bool initJoysticks(void) +{ + if (!_glfw.joysticksInitialized) + { + if (!_glfwPlatformInitJoysticks()) + { + _glfwPlatformTerminateJoysticks(); + return false; + } + } + + return _glfw.joysticksInitialized = true; +} + // Finds a mapping based on joystick GUID // static _GLFWmapping* findMapping(const char* guid) @@ -1101,6 +1117,9 @@ GLFWAPI int glfwJoystickPresent(int jid) return false; } + if (!initJoysticks()) + return false; + js = _glfw.joysticks + jid; if (!js->present) return false; @@ -1126,6 +1145,9 @@ GLFWAPI const float* glfwGetJoystickAxes(int jid, int* count) return NULL; } + if (!initJoysticks()) + return NULL; + js = _glfw.joysticks + jid; if (!js->present) return NULL; @@ -1155,6 +1177,9 @@ GLFWAPI const unsigned char* glfwGetJoystickButtons(int jid, int* count) return NULL; } + if (!initJoysticks()) + return NULL; + js = _glfw.joysticks + jid; if (!js->present) return NULL; @@ -1188,6 +1213,9 @@ GLFWAPI const unsigned char* glfwGetJoystickHats(int jid, int* count) return NULL; } + if (!initJoysticks()) + return NULL; + js = _glfw.joysticks + jid; if (!js->present) return NULL; @@ -1214,6 +1242,9 @@ GLFWAPI const char* glfwGetJoystickName(int jid) return NULL; } + if (!initJoysticks()) + return NULL; + js = _glfw.joysticks + jid; if (!js->present) return NULL; @@ -1239,6 +1270,9 @@ GLFWAPI const char* glfwGetJoystickGUID(int jid) return NULL; } + if (!initJoysticks()) + return NULL; + js = _glfw.joysticks + jid; if (!js->present) return NULL; @@ -1284,6 +1318,10 @@ GLFWAPI void* glfwGetJoystickUserPointer(int jid) GLFWAPI GLFWjoystickfun glfwSetJoystickCallback(GLFWjoystickfun cbfun) { _GLFW_REQUIRE_INIT_OR_RETURN(NULL); + + if (!initJoysticks()) + return NULL; + _GLFW_SWAP_POINTERS(_glfw.callbacks.joystick, cbfun); return cbfun; } @@ -1363,6 +1401,9 @@ GLFWAPI int glfwJoystickIsGamepad(int jid) return false; } + if (!initJoysticks()) + return false; + js = _glfw.joysticks + jid; if (!js->present) return false; @@ -1388,6 +1429,9 @@ GLFWAPI const char* glfwGetGamepadName(int jid) return NULL; } + if (!initJoysticks()) + return NULL; + js = _glfw.joysticks + jid; if (!js->present) return NULL; @@ -1420,6 +1464,9 @@ GLFWAPI int glfwGetGamepadState(int jid, GLFWgamepadstate* state) return false; } + if (!initJoysticks()) + return false; + js = _glfw.joysticks + jid; if (!js->present) return false; diff --git a/glfw/internal.h b/glfw/internal.h index feb150d0c..e020f6557 100644 --- a/glfw/internal.h +++ b/glfw/internal.h @@ -574,6 +574,7 @@ struct _GLFWlibrary _GLFWmonitor** monitors; int monitorCount; + bool joysticksInitialized; _GLFWjoystick joysticks[GLFW_JOYSTICK_LAST + 1]; _GLFWmapping* mappings; int mappingCount; @@ -667,6 +668,8 @@ void _glfwPlatformSetPrimarySelectionString(const char* string); const char* _glfwPlatformGetPrimarySelectionString(void); #endif +bool _glfwPlatformInitJoysticks(void); +void _glfwPlatformTerminateJoysticks(void); int _glfwPlatformPollJoystick(_GLFWjoystick* js, int mode); void _glfwPlatformUpdateGamepadGUID(char* guid); diff --git a/glfw/linux_joystick.c b/glfw/linux_joystick.c index d29471b38..0cde579ae 100644 --- a/glfw/linux_joystick.c +++ b/glfw/linux_joystick.c @@ -266,7 +266,7 @@ static int compareJoysticks(const void* fp, const void* sp) // Initialize joystick interface // -bool _glfwInitJoysticksLinux(void) +bool _glfwPlatformInitJoysticks(void) { const char* dirname = "/dev/input"; @@ -322,7 +322,7 @@ bool _glfwInitJoysticksLinux(void) // Close all opened joystick handles // -void _glfwTerminateJoysticksLinux(void) +void _glfwPlatformTerminateJoysticks(void) { int jid; @@ -333,14 +333,13 @@ void _glfwTerminateJoysticksLinux(void) closeJoystick(js); } - regfree(&_glfw.linjs.regex); - if (_glfw.linjs.inotify > 0) { if (_glfw.linjs.watch > 0) inotify_rm_watch(_glfw.linjs.inotify, _glfw.linjs.watch); close(_glfw.linjs.inotify); + regfree(&_glfw.linjs.regex); } } diff --git a/glfw/linux_joystick.h b/glfw/linux_joystick.h index 4870e5fcf..3a5c3300d 100644 --- a/glfw/linux_joystick.h +++ b/glfw/linux_joystick.h @@ -55,7 +55,4 @@ typedef struct _GLFWlibraryLinux bool dropped; } _GLFWlibraryLinux; - -bool _glfwInitJoysticksLinux(void); -void _glfwTerminateJoysticksLinux(void); void _glfwDetectJoystickConnectionLinux(void); diff --git a/glfw/null_joystick.c b/glfw/null_joystick.c index 2ed780b70..f3d8528f6 100644 --- a/glfw/null_joystick.c +++ b/glfw/null_joystick.c @@ -33,6 +33,15 @@ ////// GLFW platform API ////// ////////////////////////////////////////////////////////////////////////// +int _glfwPlatformInitJoysticks(void) +{ + return true; +} + +void _glfwPlatformTerminateJoysticks(void) +{ +} + int _glfwPlatformPollJoystick(_GLFWjoystick* js UNUSED, int mode UNUSED) { return false; diff --git a/glfw/wl_init.c b/glfw/wl_init.c index ae78fcbac..ed06f2d48 100644 --- a/glfw/wl_init.c +++ b/glfw/wl_init.c @@ -771,11 +771,6 @@ int _glfwPlatformInit(void) // Sync so we got all initial output events wl_display_roundtrip(_glfw.wl.display); -#ifdef __linux__ - if (!_glfwInitJoysticksLinux()) - return false; -#endif - if (!_glfw.wl.wmBase) { _glfwInputError(GLFW_PLATFORM_ERROR, @@ -799,9 +794,6 @@ int _glfwPlatformInit(void) void _glfwPlatformTerminate(void) { -#ifdef __linux__ - _glfwTerminateJoysticksLinux(); -#endif _glfwTerminateEGL(); if (_glfw.wl.egl.handle) { diff --git a/glfw/x11_init.c b/glfw/x11_init.c index c9dfa252d..80ab1601e 100644 --- a/glfw/x11_init.c +++ b/glfw/x11_init.c @@ -653,13 +653,6 @@ int _glfwPlatformInit(void) _glfw.x11.helperWindowHandle = createHelperWindow(); _glfw.x11.hiddenCursorHandle = createHiddenCursor(); -#if defined(__linux__) - if (!_glfwInitJoysticksLinux()) - return false; - if (_glfw.linjs.inotify > 0) - addWatch(&_glfw.x11.eventLoopData, "joystick", _glfw.linjs.inotify, POLLIN, 1, NULL, NULL); -#endif - _glfwPollMonitorsX11(); return true; } @@ -738,9 +731,6 @@ void _glfwPlatformTerminate(void) _glfwTerminateEGL(); _glfwTerminateGLX(); -#if defined(__linux__) - _glfwTerminateJoysticksLinux(); -#endif finalizePollData(&_glfw.x11.eventLoopData); }