KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Cleanup exit flow control for remote hostname not matching

Browse Source
This commit is contained in:
Kovid Goyal 2020-09-17 13:36:10 +05:30
parent ae475b408f
commit 7695e3a9c8
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 12 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
kittens/remote_file/main.py
View File

@ -147,7 +147,7 @@ class ControlMaster:
stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, stdin=subprocess.DEVNULL stdout=subprocess.DEVNULL, stderr=subprocess.DEVNULL, stdin=subprocess.DEVNULL
).wait() == 0 ).wait() == 0
def check_hostname_matches(self) -> None: def check_hostname_matches(self) -> bool:
cp = subprocess.run(self.batch_cmd_prefix + [self.conn_data.hostname, 'hostname', '-f'], stdout=subprocess.PIPE, cp = subprocess.run(self.batch_cmd_prefix + [self.conn_data.hostname, 'hostname', '-f'], stdout=subprocess.PIPE,
stderr=subprocess.DEVNULL, stdin=subprocess.DEVNULL) stderr=subprocess.DEVNULL, stdin=subprocess.DEVNULL)
if cp.returncode == 0: if cp.returncode == 0:
@ -170,9 +170,9 @@ class ControlMaster:
) )
sys.stdout.flush() sys.stdout.flush()
response = get_key_press('yn', 'n') response = get_key_press('yn', 'n')
if response != 'y':
raise SystemExit(1)
print(reset_terminal(), end='') print(reset_terminal(), end='')
return response == 'y'
return True
def download(self) -> bool: def download(self) -> bool:
with open(self.dest, 'wb') as f: with open(self.dest, 'wb') as f:
@ -268,7 +268,7 @@ def save_as(conn_data: SSHConnectionData, remote_path: str, cli_opts: RemoteFile
if os.path.dirname(dest): if os.path.dirname(dest):
os.makedirs(os.path.dirname(dest), exist_ok=True) os.makedirs(os.path.dirname(dest), exist_ok=True)
with ControlMaster(conn_data, remote_path, cli_opts, dest=dest) as master: with ControlMaster(conn_data, remote_path, cli_opts, dest=dest) as master:
master.check_hostname_matches() if master.check_hostname_matches():
if not master.download(): if not master.download():
show_error('Failed to copy file from remote machine') show_error('Failed to copy file from remote machine')
@ -280,14 +280,15 @@ def handle_action(action: str, cli_opts: RemoteFileCLIOptions) -> Result:
print('Opening', cli_opts.path, 'from', cli_opts.hostname) print('Opening', cli_opts.path, 'from', cli_opts.hostname)
dest = os.path.join(tempfile.mkdtemp(), os.path.basename(remote_path)) dest = os.path.join(tempfile.mkdtemp(), os.path.basename(remote_path))
with ControlMaster(conn_data, remote_path, cli_opts, dest=dest) as master: with ControlMaster(conn_data, remote_path, cli_opts, dest=dest) as master:
master.check_hostname_matches() if master.check_hostname_matches():
if master.download(): if master.download():
return dest return dest
show_error('Failed to copy file from remote machine') show_error('Failed to copy file from remote machine')
elif action == 'edit': elif action == 'edit':
print('Editing', cli_opts.path, 'from', cli_opts.hostname) print('Editing', cli_opts.path, 'from', cli_opts.hostname)
with ControlMaster(conn_data, remote_path, cli_opts) as master: with ControlMaster(conn_data, remote_path, cli_opts) as master:
master.check_hostname_matches() if not master.check_hostname_matches():
return None
if not master.download(): if not master.download():
show_error(f'Failed to download {remote_path}') show_error(f'Failed to download {remote_path}')
return None return None