KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Get rid of the query escape code for styled underlines

Browse Source
This commit is contained in:
Kovid Goyal 2018-02-04 16:40:48 +05:30
parent a1bd69a9c2
commit 6736fd3835
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
4 changed files with 0 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kitty/modes.h
View File

@ -76,8 +76,5 @@
#define BRACKETED_PASTE_START "200~" #define BRACKETED_PASTE_START "200~"
#define BRACKETED_PASTE_END "201~" #define BRACKETED_PASTE_END "201~"
// Styled underlines
#define STYLED_UNDERLINES (2016 << 5)
// Extended keyboard protocol // Extended keyboard protocol
#define EXTENDED_KEYBOARD (2017 << 5) #define EXTENDED_KEYBOARD (2017 << 5)

2
kitty/screen.c
View File

@ -1102,8 +1102,6 @@ report_mode_status(Screen *self, unsigned int which, bool private) {
KNOWN_MODE(EXTENDED_KEYBOARD); KNOWN_MODE(EXTENDED_KEYBOARD);
KNOWN_MODE(FOCUS_TRACKING); KNOWN_MODE(FOCUS_TRACKING);
#undef KNOWN_MODE #undef KNOWN_MODE
case STYLED_UNDERLINES:
ans = 3; break;
} }
int sz = snprintf(buf, sizeof(buf) - 1, "%s%u;%u$y", (private ? "?" : ""), which, ans); int sz = snprintf(buf, sizeof(buf) - 1, "%s%u;%u$y", (private ? "?" : ""), which, ans);
if (sz > 0) write_escape_code_to_child(self, CSI, buf); if (sz > 0) write_escape_code_to_child(self, CSI, buf);

3
kitty_tests/parser.py
View File

@ -160,9 +160,6 @@ class TestParser(BaseTest):
pb('\033[?1l', ('screen_reset_mode', 1, 1)) pb('\033[?1l', ('screen_reset_mode', 1, 1))
self.assertFalse(s.cursor_key_mode) self.assertFalse(s.cursor_key_mode)
c.clear() c.clear()
pb('\033[?2016$p', ('report_mode_status', 2016, 1))
self.ae(c.wtcbuf, b'\033[?2016;3$y')
c.clear()
pb('\033[?1$p', ('report_mode_status', 1, 1)) pb('\033[?1$p', ('report_mode_status', 1, 1))
self.ae(c.wtcbuf, b'\033[?1;2$y') self.ae(c.wtcbuf, b'\033[?1;2$y')
pb('\033[2;4r', ('screen_set_margins', 2, 4)) pb('\033[2;4r', ('screen_set_margins', 2, 4))

17
protocol-extensions.asciidoc
View File

@ -54,23 +54,6 @@ To reset the underline color (also previously reserved and unused):
<ESC>[59m <ESC>[59m
``` ```
A client can query if the terminal emulator supports this underline extension using the
standard link:http://vt100.net/docs/vt510-rm/DECRQM[DECRQM] escape sequence, with the
mode value `2016`, like this:
Client sends:
```
<ESC>[?2016$p
```
If the terminal supports this underline extension, it must respond with
link:http://vt100.net/docs/vt510-rm/DECRPM[DECRPM]
```
<ESC>[?2016;3$p
```
== Graphics rendering == Graphics rendering