KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

More cases of #5477 functions with empty argument lists

Browse Source 
Building on macOS 13.3.1 (22E261) clang 14.0.3 (clang-1403.0.22.14.1)
running to errors like #5477 where functions without argument lists at
least need void.

Looking for possible suspect functions via:

  git grep -E "^([A-Za-z_]+ )?[A-Za-z_]+\()" \*.c \*.m
This commit is contained in:
Derek Schrock 2023-04-16 01:08:03 -04:00
parent 77e2572c5a
commit 3b57acf03c
6 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glfw/cocoa_init.m
View File

@ -1014,7 +1014,7 @@ static pthread_t main_thread;
static NSLock *tick_lock = NULL; static NSLock *tick_lock = NULL;
void _glfwDispatchTickCallback() { void _glfwDispatchTickCallback(void) {
if (tick_lock && tick_callback) { if (tick_lock && tick_callback) {
[tick_lock lock]; [tick_lock lock];
while(tick_callback_requested) { while(tick_callback_requested) {
@ -1026,7 +1026,7 @@ void _glfwDispatchTickCallback() {
} }
static void static void
request_tick_callback() { request_tick_callback(void) {
if (!tick_callback_requested) { if (!tick_callback_requested) {
tick_callback_requested = true; tick_callback_requested = true;
[NSApp performSelectorOnMainThread:@selector(tick_callback) withObject:nil waitUntilDone:NO]; [NSApp performSelectorOnMainThread:@selector(tick_callback) withObject:nil waitUntilDone:NO];

2
glfw/cocoa_monitor.m
View File

@ -323,7 +323,7 @@ static double getFallbackRefreshRate(CGDirectDisplayID displayID)
////// GLFW internal API ////// ////// GLFW internal API //////
////////////////////////////////////////////////////////////////////////// //////////////////////////////////////////////////////////////////////////
void _glfwClearDisplayLinks() { void _glfwClearDisplayLinks(void) {
for (size_t i = 0; i < _glfw.ns.displayLinks.count; i++) { for (size_t i = 0; i < _glfw.ns.displayLinks.count; i++) {
if (_glfw.ns.displayLinks.entries[i].displayLink) { if (_glfw.ns.displayLinks.entries[i].displayLink) {
CVDisplayLinkStop(_glfw.ns.displayLinks.entries[i].displayLink); CVDisplayLinkStop(_glfw.ns.displayLinks.entries[i].displayLink);

2
kitty/cocoa_window.m
View File

@ -960,7 +960,7 @@ cocoa_set_dock_icon(PyObject UNUSED *self, PyObject *args) {
static NSSound *beep_sound = nil; static NSSound *beep_sound = nil;
static void static void
cleanup() { cleanup(void) {
@autoreleasepool { @autoreleasepool {
if (dockMenu) [dockMenu release]; if (dockMenu) [dockMenu release];

2
kitty/core_text.m
View File

@ -155,7 +155,7 @@ font_descriptor_from_python(PyObject *src) {
static CTFontCollectionRef all_fonts_collection_data = NULL; static CTFontCollectionRef all_fonts_collection_data = NULL;
static CTFontCollectionRef static CTFontCollectionRef
all_fonts_collection() { all_fonts_collection(void) {
if (all_fonts_collection_data == NULL) all_fonts_collection_data = CTFontCollectionCreateFromAvailableFonts(NULL); if (all_fonts_collection_data == NULL) all_fonts_collection_data = CTFontCollectionCreateFromAvailableFonts(NULL);
return all_fonts_collection_data; return all_fonts_collection_data;
} }

2
kitty/data-types.c
View File

@ -47,7 +47,7 @@ user_cache_dir(void) {
} }
static PyObject* static PyObject*
process_group_map() { process_group_map(void) {
int num_of_processes = proc_listallpids(NULL, 0); int num_of_processes = proc_listallpids(NULL, 0);
size_t bufsize = sizeof(pid_t) * (num_of_processes + 1024); size_t bufsize = sizeof(pid_t) * (num_of_processes + 1024);
FREE_AFTER_FUNCTION pid_t *buf = malloc(bufsize); FREE_AFTER_FUNCTION pid_t *buf = malloc(bufsize);

2
kitty/macos_process_info.c
View File

@ -24,7 +24,7 @@ cwd_of_process(PyObject *self UNUSED, PyObject *pid_) {
// Read the maximum argument size for processes // Read the maximum argument size for processes
static int static int
get_argmax() { get_argmax(void) {
int argmax; int argmax;
int mib[] = { CTL_KERN, KERN_ARGMAX }; int mib[] = { CTL_KERN, KERN_ARGMAX };
size_t size = sizeof(argmax); size_t size = sizeof(argmax);