KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixes the ssh kitten

Browse Source 
kovidgoyal@5e645a7 fixes the password file creation, allowing it to be
unlinked, but read_data_from_shared_memory/1 rejects the shared object
if it is not read only, and will break the ssh kitten for all
platforms.

This change removes the read only check, relying only on the file
ownership check.

This fully fixes #5928

Signed-off-by: Loren Schlomer <me@schlomie.com>
This commit is contained in:
Loren Schlomer 2023-01-25 11:14:12 -08:00
parent 5e645a7be7
commit 366d65f592
No known key found for this signature in database
1 changed files with 0 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
kittens/ssh/main.py
View File

@ -50,9 +50,6 @@ def read_data_from_shared_memory(shm_name: str) -> Any:
shm.unlink() shm.unlink()
if shm.stats.st_uid != os.geteuid() or shm.stats.st_gid != os.getegid(): if shm.stats.st_uid != os.geteuid() or shm.stats.st_gid != os.getegid():
raise ValueError('Incorrect owner on pwfile') raise ValueError('Incorrect owner on pwfile')
mode = stat.S_IMODE(shm.stats.st_mode)
if mode != stat.S_IREAD:
raise ValueError('Incorrect permissions on pwfile')
return json.loads(shm.read_data_with_size()) return json.loads(shm.read_data_with_size())