KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Ensure temp files dont pollute the config dir

Browse Source 
Also fix cached values not being de-serialized on python < 3.6
This commit is contained in:
Kovid Goyal 2017-01-08 17:45:03 +05:30
parent ca0786cd27
commit 334541e8dc
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
kitty/config.py
View File

@ -190,7 +190,7 @@ def load_cached_values():
cached_values.clear() cached_values.clear()
try: try:
with open(cached_path, 'rb') as f: with open(cached_path, 'rb') as f:
cached_values.update(json.loads(f.read())) cached_values.update(json.loads(f.read().decode('utf-8')))
except FileNotFoundError: except FileNotFoundError:
pass pass
except Exception as err: except Exception as err:
@ -205,3 +205,10 @@ def save_cached_values():
os.rename(p, cached_path) os.rename(p, cached_path)
except Exception as err: except Exception as err:
print('Failed to save cached values with error: {}'.format(err), file=sys.stderr) print('Failed to save cached values with error: {}'.format(err), file=sys.stderr)
finally:
try:
os.remove(p)
except FileNotFoundError:
pass
except Exception as err:
print('Failed to delete temp file for saved cached values with error: {}'.format(err), file=sys.stderr)