From 2e893690bd288108baff210f710a0d415b030c1c Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Fri, 16 Jul 2021 21:55:15 +0530 Subject: [PATCH] icat: Use scandir for slightly better performance --- kittens/icat/main.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kittens/icat/main.py b/kittens/icat/main.py index e951b892d..f18350c46 100755 --- a/kittens/icat/main.py +++ b/kittens/icat/main.py @@ -359,11 +359,11 @@ def process(path: str, args: IcatCLIOptions, parsed_opts: ParsedOpts, is_tempfil def scan(d: str) -> Generator[Tuple[str, str], None, None]: - for dirpath, dirnames, filenames in os.walk(d): - for f in filenames: - mt = guess_type(f) + for entry in os.scandir(d): + if entry.is_file(): + mt = guess_type(entry.name) if mt and mt.startswith('image/'): - yield os.path.join(dirpath, f), mt + yield entry.path, mt def detect_support(wait_for: float = 10, silent: bool = False) -> bool: