KittyPatch/kitty
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix timers not being re-sorted on replace

Browse Source
This commit is contained in:
Kovid Goyal 2017-08-27 20:42:59 +05:30
parent ff72b1f96f
commit 29b16d0856
No known key found for this signature in database
GPG Key ID: 06BC317B515ACE7C
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
kitty/timers.c
View File

@ -99,7 +99,6 @@ static PyObject *
add(Timers *self, PyObject *fargs) { add(Timers *self, PyObject *fargs) {
#define add_doc "add(delay, callback, args) -> Add callback, replacing it if it already exists" #define add_doc "add(delay, callback, args) -> Add callback, replacing it if it already exists"
size_t i; size_t i;
bool added = false;
PyObject *callback, *args = NULL; PyObject *callback, *args = NULL;
double delay, at; double delay, at;
if (!PyArg_ParseTuple(fargs, "dO|O", &delay, &callback, &args)) return NULL; if (!PyArg_ParseTuple(fargs, "dO|O", &delay, &callback, &args)) return NULL;
@ -107,18 +106,16 @@ add(Timers *self, PyObject *fargs) {
for (i = 0; i < self->count; i++) { for (i = 0; i < self->count; i++) {
if (self->events[i].callback == callback) { if (self->events[i].callback == callback) {
added = true;
self->events[i].at = at; self->events[i].at = at;
Py_CLEAR(self->events[i].args); Py_CLEAR(self->events[i].args);
self->events[i].args = args; self->events[i].args = args;
Py_XINCREF(args); Py_XINCREF(args);
break; qsort(self->events, self->count, sizeof(TimerEvent), compare_events);
Py_RETURN_NONE;
} }
} }
if (!added) return _add(self, at, callback, args); return _add(self, at, callback, args);
Py_RETURN_NONE;
} }
static PyObject * static PyObject *