From 3041ff8d2554d90df418d2fddb500568aeba03dc Mon Sep 17 00:00:00 2001 From: Fredrick Brennan Date: Sun, 30 May 2021 02:21:46 -0400 Subject: [PATCH] Downgrade libstartup-notification-1.so non-existence to warning I'm not sure how common this library actually is. On my system, an Arch Linux system with 2,170 packages installed, including KDE (Plasma), I didn't have it. It's downgraded to a warning instead of printing a traceback. --- kitty/utils.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/kitty/utils.py b/kitty/utils.py index f69ac64f0..76a52b9e5 100644 --- a/kitty/utils.py +++ b/kitty/utils.py @@ -264,7 +264,12 @@ def init_startup_notification(window_handle: Optional[int], startup_id: Optional log_error('Could not perform startup notification as window handle not present') return None try: - return init_startup_notification_x11(window_handle, startup_id) + try: + return init_startup_notification_x11(window_handle, startup_id) + except OSError as e: + if not str(e).startswith("Failed to load libstartup-notification"): + raise e + log_error("{}. This has two main effects: you won't get a loading cursor when kitty is starting up, and kitty windows may appear under wrong X11 workspace.".format(str(e))) except Exception: import traceback traceback.print_exc()