From 19bd0685994ed6b63b403d0fc59457e6118237ef Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Sun, 10 Sep 2017 12:29:36 +0530 Subject: [PATCH] Raise an error on negative scroll amounts --- kitty/screen.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kitty/screen.c b/kitty/screen.c index 69a5d7dce..f4705b06f 100644 --- a/kitty/screen.c +++ b/kitty/screen.c @@ -1336,7 +1336,10 @@ scroll(Screen *self, PyObject *args) { amt = self->historybuf->count; break; default: - amt = MAX(0, amt); + if (amt < 0) { + PyErr_SetString(PyExc_ValueError, "scroll amounts must be positive numbers"); + return NULL; + } break; } if (!upwards) {