From 0b2726ec330d0a34c05687e5aa24502cbb1619d1 Mon Sep 17 00:00:00 2001 From: Kovid Goyal Date: Thu, 17 Dec 2020 11:16:51 +0530 Subject: [PATCH] Cleanup fc_match_postscript_name --- kitty/fontconfig.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kitty/fontconfig.c b/kitty/fontconfig.c index c460506fe..79ee6d877 100644 --- a/kitty/fontconfig.c +++ b/kitty/fontconfig.c @@ -205,14 +205,15 @@ end: static PyObject* fc_match_postscript_name(PyObject UNUSED *self, PyObject *args) { - char *postscript_name = NULL; + const char *postscript_name = NULL; FcPattern *pat = NULL; PyObject *ans = NULL; - if (!PyArg_ParseTuple(args, "|z", &postscript_name)) return NULL; + if (!PyArg_ParseTuple(args, "s", &postscript_name)) return NULL; + if (!postscript_name || !postscript_name[0]) { PyErr_SetString(PyExc_KeyError, "postscript_name must not be empty"); return NULL; } + pat = FcPatternCreate(); if (pat == NULL) return PyErr_NoMemory(); - if (!postscript_name || strlen(postscript_name) == 0) return NULL; AP(FcPatternAddString, FC_POSTSCRIPT_NAME, (const FcChar8*)postscript_name, "postscript_name");